* [bug#67271] [PATCH] gnu: at-spi2-core: Honor tests? flag..
@ 2023-11-19 9:52 Zheng Junjie
2023-11-25 13:43 ` Mathieu Othacehe
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Junjie @ 2023-11-19 9:52 UTC (permalink / raw)
To: 67271; +Cc: Liliana Marie Prikler, Maxim Cournoyer, Raghav Gururajan
* gnu/packages/gtk.scm (at-spi2-core)[arguments]<#:phases>: Honor tests? flag.
Change-Id: Ie38226c0ceacd7afb54adff073c1f71eb596e10d
---
gnu/packages/gtk.scm | 46 ++++++++++++++++++++++----------------------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 67611efaae..745c3a9a55 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -811,31 +811,31 @@ (define-public at-spi2-core
(delete 'check)
;; The CI test suite fails completely on powerpc-linux.
;; The name org.gnome.SessionManager was not provided by any .service
- ;; TODO: Wrap 'check phase with 'tests?'.
#$@(if (not (target-ppc32?))
#~((add-after 'install 'check
- (lambda _
- ;; xfconfd requires a writable HOME
- (setenv "HOME" (getenv "TMPDIR"))
- ;; dbus-run-session may crash if XDG_DATA_DIRS has too
- ;; many entries, maybe related to
- ;; https://gitlab.freedesktop.org/dbus/dbus/-/issues/481.
- (setenv "XDG_DATA_DIRS"
- (string-append
- #$output "/share:"
- #$(this-package-native-input
- "gsettings-desktop-schemas")
- "/share"))
- ;; Don't fail on missing '/etc/machine-id'.
- (setenv "DBUS_FATAL_WARNINGS" "0")
- (with-directory-excursion (string-append "../at-spi2-core-"
- #$version "")
- (invoke "dbus-run-session" "--" "ci/run-registryd-tests.sh")
- (substitute* "ci/run-tests.sh"
- (("ps auxwww") "") ;avoid a dependency on procps
- (("meson test -C _build")
- "meson test -C ../build")) ;adjust build directory
- (invoke "dbus-run-session" "--" "ci/run-tests.sh")))))
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ ;; xfconfd requires a writable HOME
+ (setenv "HOME" (getenv "TMPDIR"))
+ ;; dbus-run-session may crash if XDG_DATA_DIRS has too
+ ;; many entries, maybe related to
+ ;; https://gitlab.freedesktop.org/dbus/dbus/-/issues/481.
+ (setenv "XDG_DATA_DIRS"
+ (string-append
+ #$output "/share:"
+ #$(this-package-native-input
+ "gsettings-desktop-schemas")
+ "/share"))
+ ;; Don't fail on missing '/etc/machine-id'.
+ (setenv "DBUS_FATAL_WARNINGS" "0")
+ (with-directory-excursion (string-append "../at-spi2-core-"
+ #$version "")
+ (invoke "dbus-run-session" "--" "ci/run-registryd-tests.sh")
+ (substitute* "ci/run-tests.sh"
+ (("ps auxwww") "") ;avoid a dependency on procps
+ (("meson test -C _build")
+ "meson test -C ../build")) ;adjust build directory
+ (invoke "dbus-run-session" "--" "ci/run-tests.sh"))))))
#~()))))
(inputs
(list bash-minimal libxml2))
base-commit: 1cc3b7e80f60a2a5a6a1400ed0b025efeae7a523
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#67271] [PATCH] gnu: at-spi2-core: Honor tests? flag..
2023-11-19 9:52 [bug#67271] [PATCH] gnu: at-spi2-core: Honor tests? flag Zheng Junjie
@ 2023-11-25 13:43 ` Mathieu Othacehe
2023-11-29 10:51 ` Zheng Junjie
2023-12-31 6:09 ` Maxim Cournoyer
0 siblings, 2 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2023-11-25 13:43 UTC (permalink / raw)
To: Zheng Junjie
Cc: Raghav Gururajan, Maxim Cournoyer, Liliana Marie Prikler, 67271
Hello,
> * gnu/packages/gtk.scm (at-spi2-core)[arguments]<#:phases>: Honor tests? flag.
Could you please rebase it on top of
9210ca9b0498d3360ee247841a6bd212d6aa8ec4?
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#67271] [PATCH] gnu: at-spi2-core: Honor tests? flag..
2023-11-25 13:43 ` Mathieu Othacehe
@ 2023-11-29 10:51 ` Zheng Junjie
2023-12-31 6:09 ` Maxim Cournoyer
1 sibling, 0 replies; 4+ messages in thread
From: Zheng Junjie @ 2023-11-29 10:51 UTC (permalink / raw)
To: Mathieu Othacehe
Cc: Raghav Gururajan, Maxim Cournoyer, Zheng Junjie,
Liliana Marie Prikler, 67271
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hello,
>
>> * gnu/packages/gtk.scm (at-spi2-core)[arguments]<#:phases>: Honor tests? flag.
>
> Could you please rebase it on top of
> 9210ca9b0498d3360ee247841a6bd212d6aa8ec4?
sorry, this patch should prefix with [PATCH gnome-term]
>
> Thanks,
>
> Mathieu
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#67271] [PATCH] gnu: at-spi2-core: Honor tests? flag..
2023-11-25 13:43 ` Mathieu Othacehe
2023-11-29 10:51 ` Zheng Junjie
@ 2023-12-31 6:09 ` Maxim Cournoyer
1 sibling, 0 replies; 4+ messages in thread
From: Maxim Cournoyer @ 2023-12-31 6:09 UTC (permalink / raw)
To: Mathieu Othacehe
Cc: Raghav Gururajan, Zheng Junjie, Liliana Marie Prikler, 67271
Hi,
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hello,
>
>> * gnu/packages/gtk.scm (at-spi2-core)[arguments]<#:phases>: Honor tests? flag.
>
> Could you please rebase it on top of
> 9210ca9b0498d3360ee247841a6bd212d6aa8ec4?
Is this core-updates?
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-31 6:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-19 9:52 [bug#67271] [PATCH] gnu: at-spi2-core: Honor tests? flag Zheng Junjie
2023-11-25 13:43 ` Mathieu Othacehe
2023-11-29 10:51 ` Zheng Junjie
2023-12-31 6:09 ` Maxim Cournoyer
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.