all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: rustc: Retain binutils.
Date: Mon, 09 Jan 2017 23:59:40 +0100	[thread overview]
Message-ID: <8737gr3kmb.fsf@gnu.org> (raw)
In-Reply-To: <20170109134534.15933-1-david@craven.ch> (David Craven's message of "Mon, 9 Jan 2017 14:45:34 +0100")

David Craven <david@craven.ch> skribis:

> * gnu/packages/rust.scm (rustc)[arguments]: Retain binutils. Add
>   wrap-rustc phase.
>
> Problem reported by Ben Woodcroft <donttrustben@gmail.com>.

LGTM!

> An idea: How about adding tests for packages?
>
> A simple compile check for a compiler or something like that. The
> problem with manual testing is that the environment could hide bugs.
> This would make sure that dependencies are retained and programs are
> wrapped etc.
>
> Useful or not?

In most cases “make check” would find the problems.  In cases where
there might be problems post-installation, we could always add a phase
that runs the thing.

Thanks,
Ludo’.

      parent reply	other threads:[~2017-01-09 22:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 13:45 [PATCH] gnu: rustc: Retain binutils David Craven
2017-01-09 14:05 ` David Craven
2017-01-09 22:59 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737gr3kmb.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.