From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: rustc: Retain binutils.
Date: Mon, 09 Jan 2017 23:59:40 +0100
Message-ID: <8737gr3kmb.fsf@gnu.org>
References: <20170109134534.15933-1-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51643)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cQiuo-0006mk-9f
	for guix-devel@gnu.org; Mon, 09 Jan 2017 17:59:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cQiul-0005v1-9G
	for guix-devel@gnu.org; Mon, 09 Jan 2017 17:59:46 -0500
In-Reply-To: <20170109134534.15933-1-david@craven.ch> (David Craven's message
	of "Mon, 9 Jan 2017 14:45:34 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/packages/rust.scm (rustc)[arguments]: Retain binutils. Add
>   wrap-rustc phase.
>
> Problem reported by Ben Woodcroft <donttrustben@gmail.com>.

LGTM!

> An idea: How about adding tests for packages?
>
> A simple compile check for a compiler or something like that. The
> problem with manual testing is that the environment could hide bugs.
> This would make sure that dependencies are retained and programs are
> wrapped etc.
>
> Useful or not?

In most cases =E2=80=9Cmake check=E2=80=9D would find the problems.  In cas=
es where
there might be problems post-installation, we could always add a phase
that runs the thing.

Thanks,
Ludo=E2=80=99.