all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>
Subject: Re: [PATCH] website: packages: Anchor location url to commit id.
Date: Tue, 14 Feb 2017 17:20:23 +0100	[thread overview]
Message-ID: <8737fgu4l4.fsf@gnu.org> (raw)
In-Reply-To: <20170213154527.tbiw7z4to7lumis5@wasp> (ng0's message of "Mon, 13 Feb 2017 15:45:27 +0000")

ng0 <contact.ng0@cryptolab.net> skribis:

> On 17-02-13 15:35:25, Ludovic Courtès wrote:
>> ericbavier@openmailbox.org skribis:
>> 
>> > From: Eric Bavier <bavier@member.fsf.org>
>> >
>> > * website/www/packages.scm (git-description): New variable.
>> > (location-url): Include "?id=..." if possible.
>> 
>> Looks like a good idea, please push!
>> 
>> Thanks,
>> Ludo'.
>> 
> As a follow-up I think we could also use this now:
>
> (string-append "//git.savannah.gnu.org/cgit/guix.git/tree/"
>                (location-file loc) "#n"
>                (number->string (location-line loc))))
>
> And the same for other instances of git.savannah.gnu.org,
> what do you think?

Good idea.  Done in commit f3ad5e8422b6375029e1526eeb9ea2909b157181 of
guix-artwork.git.

> There are other "http" in the pages which could be replaced with // as
> well (for example hydra.gnu.org).

Don’t hesitate to send a patch if you spot other similar issues.

Thanks!

Ludo’.

      reply	other threads:[~2017-02-14 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-12  2:05 [PATCH] website: packages: Anchor location url to commit id ericbavier
2017-02-13 14:35 ` Ludovic Courtès
2017-02-13 15:45   ` ng0
2017-02-14 16:20     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737fgu4l4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=bavier@member.fsf.org \
    --cc=ericbavier@openmailbox.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.