From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] website: packages: Anchor location url to commit id.
Date: Tue, 14 Feb 2017 17:20:23 +0100
Message-ID: <8737fgu4l4.fsf@gnu.org>
References: <20170212020520.812-1-ericbavier@openmailbox.org>
	<87poimcg5u.fsf@gnu.org> <20170213154527.tbiw7z4to7lumis5@wasp>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41627)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cdfqB-0000Ls-2i
	for guix-devel@gnu.org; Tue, 14 Feb 2017 11:20:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cdfq9-0003uv-WF
	for guix-devel@gnu.org; Tue, 14 Feb 2017 11:20:31 -0500
In-Reply-To: <20170213154527.tbiw7z4to7lumis5@wasp> (ng0's message of "Mon, 13
	Feb 2017 15:45:27 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

ng0 <contact.ng0@cryptolab.net> skribis:

> On 17-02-13 15:35:25, Ludovic Court=C3=A8s wrote:
>> ericbavier@openmailbox.org skribis:
>>=20
>> > From: Eric Bavier <bavier@member.fsf.org>
>> >
>> > * website/www/packages.scm (git-description): New variable.
>> > (location-url): Include "?id=3D..." if possible.
>>=20
>> Looks like a good idea, please push!
>>=20
>> Thanks,
>> Ludo'.
>>=20
> As a follow-up I think we could also use this now:
>
> (string-append "//git.savannah.gnu.org/cgit/guix.git/tree/"
>                (location-file loc) "#n"
>                (number->string (location-line loc))))
>
> And the same for other instances of git.savannah.gnu.org,
> what do you think?

Good idea.  Done in commit f3ad5e8422b6375029e1526eeb9ea2909b157181 of
guix-artwork.git.

> There are other "http" in the pages which could be replaced with // as
> well (for example hydra.gnu.org).

Don=E2=80=99t hesitate to send a patch if you spot other similar issues.

Thanks!

Ludo=E2=80=99.