all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Dave Love <fx@gnu.org>
Cc: 28593-done@debbugs.gnu.org,
	Paul Garlick <pgarlick@tourbillion-technology.com>
Subject: bug#28593: [PATCH] gnu: openfoam: Clean up to reduce closure.
Date: Fri, 01 Dec 2017 11:27:57 +0100	[thread overview]
Message-ID: <87374uivyq.fsf@gnu.org> (raw)
In-Reply-To: <874lqrjh0y.fsf@albion.it.manchester.ac.uk> (Dave Love's message of "Sun, 22 Oct 2017 17:15:09 +0100")

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Dave Love <fx@gnu.org> skribis:

>>From dc88db3e91c70da5e6e557ed5fdd528499cb1c65 Mon Sep 17 00:00:00 2001
> From: Dave Love <fx@gnu.org>
> Date: Sat, 21 Oct 2017 17:20:42 +0100
> Subject: [PATCH] gnu: openfoam: Clean up to reduce closure.
>
> This saves ~1GB.
>
> * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug.
> [arguments]: Clean up .o and src after build.

I removed the FIXME as suggested by Paul, made the changes below, and
committed.

Thank you,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1349 bytes --]

diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
index 3e65d1687..a5b661e34 100644
--- a/gnu/packages/simulation.scm
+++ b/gnu/packages/simulation.scm
@@ -84,8 +84,6 @@
      `(("gzip" ,gzip)
        ("gnuplot" ,gnuplot)
        ("openmpi" ,openmpi)))
-    ;; FIXME: Also separate tutorials (80MB) and src (60MB); maybe also doc
-    ;; (8MB)
     (outputs '("debug"                  ;~60MB
                "out"))
     (arguments
@@ -176,14 +174,14 @@
                          "lockDir=$HOME/.$WM_PROJECT/.wmake\n"))
                       #t))
                   (add-after 'build 'cleanup
-                    ;; Avoid unncessary, voluminous object and dep files
+                    ;; Avoid unncessary, voluminous object and dep files.
                     (lambda _
                       (delete-file-recursively
                        "platforms/linux64GccDPInt32Opt/src")
                       (delete-file-recursively
                        "platforms/linux64GccDPInt32OptSYSTEMOPENMPI")
-                      (zero?
-                       (system* "find" "-name" "*.o" "-delete"))))
+                      (for-each delete-file (find-files "." "\\.o$"))
+                      #t))
                   (replace 'install
                     (lambda _
                       ;; use 'OpenFOAM-version' convention

  parent reply	other threads:[~2017-12-01 10:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 10:44 [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure Dave Love
2017-09-25 12:52 ` Ludovic Courtès
2017-09-26 11:40   ` Paul Garlick
2017-09-26 12:08     ` Ludovic Courtès
2017-09-27 21:30       ` Dave Love
2017-09-28  8:36         ` Ludovic Courtès
2017-10-02 20:41           ` Dave Love
2017-10-03 12:33             ` Ludovic Courtès
2017-10-07 20:45       ` Ludovic Courtès
2017-10-09 11:06         ` Paul Garlick
2017-10-19 11:06           ` Dave Love
2017-10-19 12:15             ` Ludovic Courtès
2017-10-20 10:32               ` Paul Garlick
2017-10-20 11:28                 ` Ludovic Courtès
2017-10-20 15:28                   ` Dave Love
2017-10-20 15:26                 ` Dave Love
2017-10-22 16:15           ` Dave Love
2017-10-23 15:00             ` Paul Garlick
2017-12-01 10:27             ` Ludovic Courtès [this message]
2017-09-27 21:25     ` Dave Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87374uivyq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=28593-done@debbugs.gnu.org \
    --cc=fx@gnu.org \
    --cc=pgarlick@tourbillion-technology.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.