From: Paul Garlick <pgarlick@tourbillion-technology.com>
To: Dave Love <fx@gnu.org>
Cc: 28593@debbugs.gnu.org
Subject: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure.
Date: Mon, 23 Oct 2017 16:00:11 +0100 [thread overview]
Message-ID: <1508770811.11712.19.camel@tourbillion-technology.com> (raw)
In-Reply-To: <874lqrjh0y.fsf@albion.it.manchester.ac.uk>
On Sun, 2017-10-22 at 17:15 +0100, Dave Love wrote:
>
> I successfully rebuilt pisoFoam following the example in the current
> documentation. Is that good enough?
Yes, that is a good example case. Thank you for doing the check.
> Here's a modified patch to change the comment and avoid an empty
> directory.
Fine, with a caveat on the FIXME comment:
i) 'wmake' will fail to find headers in subdirectories of 'src' if they
are not installed. So, a re-compilation as you did above would not be
possible without installing the extra output. This is perhaps
confusing for a new user, who may not know the details of the
dependency structure.
ii) OpenFOAM would be difficult to use without the 'tutorials'
directory, as these are often used as the starting point for new
development. I think it is helpful for these files to be installed by
default.
My own preference would be to not fix the FIXME (or, in fact, to omit
the comment at this stage).
Best,
Paul.
next prev parent reply other threads:[~2017-10-23 15:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 10:44 [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure Dave Love
2017-09-25 12:52 ` Ludovic Courtès
2017-09-26 11:40 ` Paul Garlick
2017-09-26 12:08 ` Ludovic Courtès
2017-09-27 21:30 ` Dave Love
2017-09-28 8:36 ` Ludovic Courtès
2017-10-02 20:41 ` Dave Love
2017-10-03 12:33 ` Ludovic Courtès
2017-10-07 20:45 ` Ludovic Courtès
2017-10-09 11:06 ` Paul Garlick
2017-10-19 11:06 ` Dave Love
2017-10-19 12:15 ` Ludovic Courtès
2017-10-20 10:32 ` Paul Garlick
2017-10-20 11:28 ` Ludovic Courtès
2017-10-20 15:28 ` Dave Love
2017-10-20 15:26 ` Dave Love
2017-10-22 16:15 ` Dave Love
2017-10-23 15:00 ` Paul Garlick [this message]
2017-12-01 10:27 ` bug#28593: " Ludovic Courtès
2017-09-27 21:25 ` [bug#28593] " Dave Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508770811.11712.19.camel@tourbillion-technology.com \
--to=pgarlick@tourbillion-technology.com \
--cc=28593@debbugs.gnu.org \
--cc=fx@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.