From: "Ludovic Courtès" <ludo@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 36132@debbugs.gnu.org, 35901@debbugs.gnu.org
Subject: [bug#36132] [PATCH 2/2] installer: Show, don't Hide.
Date: Tue, 11 Jun 2019 10:05:56 +0200 [thread overview]
Message-ID: <8736kg7di3.fsf@gnu.org> (raw)
In-Reply-To: <20190608044729.14700-2-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Sat, 8 Jun 2019 06:47:29 +0200")
Hi,
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> * gnu/installer/newt/user.scm (run-user-add-page): Change the input
> visibility checkbox's text to ‘Show’, and default to unchecked.
> * gnu/installer/newt/page.scm (run-input-page): Likewise.
> Rename INPUT-HIDE-CHECKBOX? argument to INPUT-SHOW-CHECKBOX?.
I think the argument should perhaps be ‘input-visibility-checkbox?’,
otherwise I find it a bit unclear (both before and after the patch
actually.)
Other than that LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2019-06-11 8:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 4:42 [bug#36132] Two installer UX tweaks Tobias Geerinckx-Rice
2019-06-08 4:47 ` [bug#36132] [PATCH 1/2] installer: Partition as the last step Tobias Geerinckx-Rice
2019-06-08 4:47 ` [bug#36132] [PATCH 2/2] installer: Show, don't Hide Tobias Geerinckx-Rice
2019-06-11 8:05 ` Ludovic Courtès [this message]
2019-06-11 8:02 ` [bug#36132] [PATCH 1/2] installer: Partition as the last step Ludovic Courtès
2019-08-26 14:23 ` [bug#35901] " Tobias Geerinckx-Rice via Guix-patches via
2019-08-26 14:00 ` bug#36132: Two installer UX tweaks Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736kg7di3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35901@debbugs.gnu.org \
--cc=36132@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.