From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:46117)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1habo8-0001lA-51
 for guix-patches@gnu.org; Tue, 11 Jun 2019 04:07:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1habo7-0006cI-8v
 for guix-patches@gnu.org; Tue, 11 Jun 2019 04:07:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:44424)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1habo7-0006cE-6J
 for guix-patches@gnu.org; Tue, 11 Jun 2019 04:07:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1habo7-0000dM-0D
 for guix-patches@gnu.org; Tue, 11 Jun 2019 04:07:03 -0400
Subject: [bug#36132] [PATCH 2/2] installer: Show, don't Hide.
Resent-Message-ID: <handler.36132.B36132.15602403692364@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87y32c663d.fsf@nckx> <20190608044729.14700-1-me@tobias.gr>
 <20190608044729.14700-2-me@tobias.gr>
Date: Tue, 11 Jun 2019 10:05:56 +0200
In-Reply-To: <20190608044729.14700-2-me@tobias.gr> (Tobias Geerinckx-Rice's
 message of "Sat, 8 Jun 2019 06:47:29 +0200")
Message-ID: <8736kg7di3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 36132@debbugs.gnu.org, 35901@debbugs.gnu.org

Hi,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/installer/newt/user.scm (run-user-add-page): Change the input
> visibility checkbox's text to =E2=80=98Show=E2=80=99, and default to unch=
ecked.
> * gnu/installer/newt/page.scm (run-input-page): Likewise.
> Rename INPUT-HIDE-CHECKBOX? argument to INPUT-SHOW-CHECKBOX?.

I think the argument should perhaps be =E2=80=98input-visibility-checkbox?=
=E2=80=99,
otherwise I find it a bit unclear (both before and after the patch
actually.)

Other than that LGTM, thank you!

Ludo=E2=80=99.