From: Marius Bakke <marius@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>, 42283@debbugs.gnu.org
Subject: [bug#42283] [PATCH] gnu: Add adlplug.
Date: Tue, 21 Jul 2020 00:55:34 +0200 [thread overview]
Message-ID: <87365lhk49.fsf@gnu.org> (raw)
In-Reply-To: <16c9b7c18396f37fd15cc570edb808f08dc8849f.camel@zrythm.org>
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
Alexandros Theodotou <alex@zrythm.org> writes:
> Hi,
>
> This patch adds the ADLPlug LV2 plugin.
[...]
> * gnu/packages/music.scm (adlplug): New variable.
[...]
> +(define-public adlplug
> + (package
> + (name "adlplug")
> + (version "1.0.1")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/jpcima/ADLplug.git")
> + (commit (string-append "v" version))
> + (recursive? #t))) ; uses 3rd party submodules
Is it possible to package these modules separately?
One of the submodules, uses a seemingly non-free license:
https://juce.com/juce-5-license
Interestingly, it becomes a free license (GPL3) once you exceed a
certain revenue!?
IANAL and only had a cursory look, but am not comfortable adding this
without a larger discussion. A good first step would be to package JUCE
separately and take it from there.
The other bundled packages seem fine, but it would be comforting to have
them in Guix even if this package needs the bundled versions. I also
think we should mention their licenses -- especially since vst3sdk is
available as either a proprietary license or GPL3, and taking the latter
implies that this package _also_ becomes GPL3.
(btw, the bundled fmt library is already available)
So, this will be a tricky one. Do you think you can look into packaging
the bundled components separately?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-07-20 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 21:47 [bug#42283] [PATCH] gnu: Add adlplug Alexandros Theodotou
2020-07-20 22:55 ` Marius Bakke [this message]
2020-07-20 23:18 ` Alexandros Theodotou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87365lhk49.fsf@gnu.org \
--to=marius@gnu.org \
--cc=42283@debbugs.gnu.org \
--cc=alex@zrythm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.