From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YP6bMgkhFl/6bwAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 22:56:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OLZRLgkhFl/DGgAAbx9fmQ (envelope-from ) for ; Mon, 20 Jul 2020 22:56:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C55FB940AC5 for ; Mon, 20 Jul 2020 22:56:08 +0000 (UTC) Received: from localhost ([::1]:33740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxeha-00076c-BJ for larch@yhetil.org; Mon, 20 Jul 2020 18:56:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxehW-00076K-1y for guix-patches@gnu.org; Mon, 20 Jul 2020 18:56:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxehV-0006yv-P1 for guix-patches@gnu.org; Mon, 20 Jul 2020 18:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxehV-0000mj-O0 for guix-patches@gnu.org; Mon, 20 Jul 2020 18:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42283] [PATCH] gnu: Add adlplug. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Jul 2020 22:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42283 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandros Theodotou , 42283@debbugs.gnu.org Received: via spool by 42283-submit@debbugs.gnu.org id=B42283.15952857543004 (code B ref 42283); Mon, 20 Jul 2020 22:56:01 +0000 Received: (at 42283) by debbugs.gnu.org; 20 Jul 2020 22:55:54 +0000 Received: from localhost ([127.0.0.1]:36629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxehN-0000mO-LO for submit@debbugs.gnu.org; Mon, 20 Jul 2020 18:55:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxehL-0000mB-I9 for 42283@debbugs.gnu.org; Mon, 20 Jul 2020 18:55:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42839) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxehF-0006sM-37; Mon, 20 Jul 2020 18:55:45 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:59914 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jxehE-0000Sy-3H; Mon, 20 Jul 2020 18:55:44 -0400 From: Marius Bakke In-Reply-To: <16c9b7c18396f37fd15cc570edb808f08dc8849f.camel@zrythm.org> References: <16c9b7c18396f37fd15cc570edb808f08dc8849f.camel@zrythm.org> Date: Tue, 21 Jul 2020 00:55:34 +0200 Message-ID: <87365lhk49.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: fWKgw0OpTQRD --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alexandros Theodotou writes: > Hi, > > This patch adds the ADLPlug LV2 plugin. [...] > * gnu/packages/music.scm (adlplug): New variable. [...] =20=20 > +(define-public adlplug > + (package > + (name "adlplug") > + (version "1.0.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/jpcima/ADLplug.git") > + (commit (string-append "v" version)) > + (recursive? #t))) ; uses 3rd party submodules Is it possible to package these modules separately? One of the submodules, uses a seemingly non-free license: https://juce.com/juce-5-license Interestingly, it becomes a free license (GPL3) once you exceed a certain revenue!? IANAL and only had a cursory look, but am not comfortable adding this without a larger discussion. A good first step would be to package JUCE separately and take it from there. The other bundled packages seem fine, but it would be comforting to have them in Guix even if this package needs the bundled versions. I also think we should mention their licenses -- especially since vst3sdk is available as either a proprietary license or GPL3, and taking the latter implies that this package _also_ becomes GPL3. (btw, the bundled fmt library is already available) So, this will be a tricky one. Do you think you can look into packaging the bundled components separately? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8WIOcACgkQoqBt8qM6 VPrahgf/QYXThvOKFx3O6Qk4uwX4A0yIGWo1nDK1CbHmBeN1PvkVilT8FoPv+5fZ f77OOaTDH5ICZza457HrHjPz7oKJEgYN0VbCp5pNvRGurGsiyb8V7/uL3kNB5FBD ZE5bi9YDeupLqcTpPIDf+YBWNykqaStwfM/zA0eGzOpl00Jz3VS1cXyoYAdY7Sdg 7wxnqHIOnM0KKOKxKgY7ovbRnAj6aD8HBcxvAmb8F/mU9+8a9fnjBEPt/WgXgwtm yG6qXa3vre68omz4QS/N7sHMmz9uOBljJfAlAqta+Zf+9pz0SWR1R/7lqlmR4CK4 aLwA/UICyfZiT8xAWmH53nM5sYQ3kA== =6Zxn -----END PGP SIGNATURE----- --=-=-=--