From: Christopher Baines <mail@cbaines.net>
To: Simon South <simon@simonsouth.net>
Cc: 60429@debbugs.gnu.org
Subject: [bug#60429] [PATCH v2 4/5] gnu: yosys: Propagate external dependencies.
Date: Wed, 08 Feb 2023 17:14:59 +0000 [thread overview]
Message-ID: <87357g6pfz.fsf@cbaines.net> (raw)
In-Reply-To: <62b19db61f34b63e37ba204fd9691b97d5c245bb.1673202235.git.simon@simonsouth.net>
[-- Attachment #1: Type: text/plain, Size: 2516 bytes --]
Simon South <simon@simonsouth.net> writes:
> * gnu/packages/fpga.scm (yosys)[inputs]: Move graphviz, psmisc, xdot from
> here...
> [propagated-inputs]: ...to here, to ensure the availability at runtime of
> executables invoked by yosys' "show" command.
> [arguments]: Remove now-obsolete "fix-paths" phase.
> ---
> gnu/packages/fpga.scm | 20 +++++---------------
> 1 file changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
> index 8effebd921..785d385621 100644
> --- a/gnu/packages/fpga.scm
> +++ b/gnu/packages/fpga.scm
> @@ -157,16 +157,6 @@ (define-public yosys
> (string-append "PREFIX=" #$output))
> #:phases
> #~(modify-phases %standard-phases
> - (add-before 'configure 'fix-paths
> - (lambda* (#:key inputs #:allow-other-keys)
> - (substitute* "./passes/cmds/show.cc"
> - (("exec xdot")
> - (string-append "exec " (search-input-file inputs
> - "/bin/xdot")))
> - (("dot -")
> - (string-append (search-input-file inputs "/bin/dot") " -"))
> - (("fuser")
> - (search-input-file inputs "/bin/fuser")))))
> (replace 'configure
> (lambda* (#:key make-flags #:allow-other-keys)
> (apply invoke "make" "config-gcc" make-flags)))
> @@ -211,14 +201,14 @@ (define-public yosys
> python
> tcl)) ; tclsh for the tests
> (inputs
> - (list graphviz
> - libffi
> - psmisc
> + (list libffi
> readline
> - tcl
> - xdot))
> + tcl))
> (propagated-inputs
> (list abc
> + graphviz ; for dot
> + psmisc ; for fuser
> + xdot
> z3)) ; should be in path for yosys-smtbmc
> (home-page "https://yosyshq.net/yosys/")
> (synopsis "FPGA Verilog RTL synthesizer")
Thanks Simon, I've pushed the first 3 patches from this series to the
master branch now.
For the changes regarding propagated-inputs though, I'm not sure this it
the right direction. Firstly, I think it's possible (and maybe
desirable) to keep the 'fix-paths phase, even if the inputs are changed
to be propagated.
I know you say this is related to yosys show in the commit message, can
you elaborate on why these packages are necessary to have in the users
environment?
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2023-02-08 17:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 15:58 [bug#60429] [PATCH 0/5] gnu: yosys: Update to 0.24 Simon South
2022-12-30 16:00 ` [bug#60429] [PATCH 1/5] gnu: yosys: Update source and home-page URLs Simon South
2022-12-30 16:00 ` [bug#60429] [PATCH 2/5] gnu: yosys: Use new package style Simon South
2022-12-30 16:00 ` [bug#60429] [PATCH 3/5] gnu: yosys: Use external abc Simon South
2022-12-30 16:00 ` [bug#60429] [PATCH 4/5] gnu: yosys: Propagate external dependencies Simon South
2022-12-30 16:00 ` [bug#60429] [PATCH 5/5] gnu: yosys: Update to 0.24 Simon South
2023-01-08 18:31 ` [bug#60429] [PATCH v2 0/5] " Simon South
2023-01-08 18:31 ` [bug#60429] [PATCH v2 1/5] gnu: yosys: Update source and home-page URLs Simon South
2023-01-08 18:31 ` [bug#60429] [PATCH v2 2/5] gnu: yosys: Use new package style Simon South
2023-01-08 18:31 ` [bug#60429] [PATCH v2 3/5] gnu: yosys: Use external abc Simon South
2023-01-08 18:31 ` [bug#60429] [PATCH v2 4/5] gnu: yosys: Propagate external dependencies Simon South
2023-02-08 17:14 ` Christopher Baines [this message]
2023-02-09 0:35 ` Simon South
2023-02-09 5:29 ` Liliana Marie Prikler
2023-02-09 16:47 ` Simon South
2023-01-08 18:31 ` [bug#60429] [PATCH v2 5/5] gnu: yosys: Update to 0.25 Simon South
2023-02-10 13:16 ` [bug#60429] [PATCH v3 0/5] gnu: yosys: Update to 0.24 Simon South
2023-02-10 13:16 ` [bug#60429] [PATCH v3 4/5] gnu: yosys: Do not propagate any inputs Simon South
2023-02-10 13:16 ` [bug#60429] [PATCH v3 5/5] gnu: yosys: Update to 0.26 Simon South
2023-02-11 20:38 ` bug#60429: [PATCH v3 0/5] gnu: yosys: Update to 0.24 Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87357g6pfz.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=60429@debbugs.gnu.org \
--cc=simon@simonsouth.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.