From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gOj7CQHb42PUVgEAbAwnHQ (envelope-from ) for ; Wed, 08 Feb 2023 18:25:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YPTyCAHb42N//wAAG6o9tA (envelope-from ) for ; Wed, 08 Feb 2023 18:25:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C83B41B2B for ; Wed, 8 Feb 2023 18:25:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPoBz-0005XE-1M; Wed, 08 Feb 2023 12:25:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPoBs-0005WI-SB for guix-patches@gnu.org; Wed, 08 Feb 2023 12:25:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPoBq-000742-75 for guix-patches@gnu.org; Wed, 08 Feb 2023 12:25:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPoBp-0006Sf-Lr for guix-patches@gnu.org; Wed, 08 Feb 2023 12:25:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60429] [PATCH v2 4/5] gnu: yosys: Propagate external dependencies. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Feb 2023 17:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60429 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon South Cc: 60429@debbugs.gnu.org X-Debbugs-Original-Cc: 60429@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167587705424749 (code B ref -1); Wed, 08 Feb 2023 17:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Feb 2023 17:24:14 +0000 Received: from localhost ([127.0.0.1]:56555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPoB3-0006R7-Kt for submit@debbugs.gnu.org; Wed, 08 Feb 2023 12:24:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:40914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPoAz-0006Qq-Lm for submit@debbugs.gnu.org; Wed, 08 Feb 2023 12:24:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPoAz-0005Rf-9T for guix-patches@gnu.org; Wed, 08 Feb 2023 12:24:09 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPoAx-00060L-BK for guix-patches@gnu.org; Wed, 08 Feb 2023 12:24:08 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 8655116303; Wed, 8 Feb 2023 17:24:04 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 633e2305; Wed, 8 Feb 2023 17:24:03 +0000 (UTC) References: <62b19db61f34b63e37ba204fd9691b97d5c245bb.1673202235.git.simon@simonsouth.net> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Wed, 08 Feb 2023 17:14:59 +0000 In-reply-to: <62b19db61f34b63e37ba204fd9691b97d5c245bb.1673202235.git.simon@simonsouth.net> Message-ID: <87357g6pfz.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675877120; a=rsa-sha256; cv=none; b=BNYIdMlbr80PEdjNVBy4uG/FSoo1fd34QVNAuLeMS2JfRWKYJJQLjiAk3MhO7//stt41gj 8c/l38Bt6RV1VlOHXaYcc3ehprX8kmbg8Cu9rDAzGzg2WoDyiN6L+RbMtvr1288xuor/Kg Tl0CRpiD7vxkbPTQYDnlLuH7TeGOPJnZlnUsA/MBA5I9HXKxRtQ0rye2W1UpOk+vDpSomW QBrGfhc/dJ7ZFXLYffFmpQLLrUvAdp5TnfERPulPvSUGk/R6tQcrbVEuUnsqJwul9YPQ7t ih9MhtEzHVJcrN8uXVGr4LQqevNwVOP+dj9H/hzKhFFrLHILQlzI9Nrz+3bcqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675877120; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Ry9ZsF1qQIsKol8ns+24Ff+TGdIw4KudXnGYU9qfmew=; b=uQ0puaJ3GyYRSypHDB9JPJ9O6O1ygnXSnSmDs5jE6fnK0YqAVO8iJNOunVrszOymJJNtEt YgThC6A+la/wI/gShQhOCsd4b61TS65MKykZ1QwqGnArxhAhTRNTNVjubpWvSuMv03/P3r t+VnGPP/HnhH3PfnrLRBrwqQ/3tCknBqS5lPZ0rdIRBkfRRZjhXVZzvlTw5WW8Qt+FCqQ6 zs6HP1WM9GpmIm0nBWu0G8S3rVpfdgnbPgqScIdd0Gss4m6VX/eVRR6J1ZB2V2E7Iwn0ZA 5PfbBoUoX7G/mcPCsZ9FoNgQwCWDNX9J1yDLyebpEosywmNpZUFi+1N1zlDpsg== X-Migadu-Queue-Id: C83B41B2B X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -6.40 X-Spam-Score: -6.40 X-TUID: oozizgt+RbcH --=-=-= Content-Type: text/plain Simon South writes: > * gnu/packages/fpga.scm (yosys)[inputs]: Move graphviz, psmisc, xdot from > here... > [propagated-inputs]: ...to here, to ensure the availability at runtime of > executables invoked by yosys' "show" command. > [arguments]: Remove now-obsolete "fix-paths" phase. > --- > gnu/packages/fpga.scm | 20 +++++--------------- > 1 file changed, 5 insertions(+), 15 deletions(-) > > diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm > index 8effebd921..785d385621 100644 > --- a/gnu/packages/fpga.scm > +++ b/gnu/packages/fpga.scm > @@ -157,16 +157,6 @@ (define-public yosys > (string-append "PREFIX=" #$output)) > #:phases > #~(modify-phases %standard-phases > - (add-before 'configure 'fix-paths > - (lambda* (#:key inputs #:allow-other-keys) > - (substitute* "./passes/cmds/show.cc" > - (("exec xdot") > - (string-append "exec " (search-input-file inputs > - "/bin/xdot"))) > - (("dot -") > - (string-append (search-input-file inputs "/bin/dot") " -")) > - (("fuser") > - (search-input-file inputs "/bin/fuser"))))) > (replace 'configure > (lambda* (#:key make-flags #:allow-other-keys) > (apply invoke "make" "config-gcc" make-flags))) > @@ -211,14 +201,14 @@ (define-public yosys > python > tcl)) ; tclsh for the tests > (inputs > - (list graphviz > - libffi > - psmisc > + (list libffi > readline > - tcl > - xdot)) > + tcl)) > (propagated-inputs > (list abc > + graphviz ; for dot > + psmisc ; for fuser > + xdot > z3)) ; should be in path for yosys-smtbmc > (home-page "https://yosyshq.net/yosys/") > (synopsis "FPGA Verilog RTL synthesizer") Thanks Simon, I've pushed the first 3 patches from this series to the master branch now. For the changes regarding propagated-inputs though, I'm not sure this it the right direction. Firstly, I think it's possible (and maybe desirable) to keep the 'fix-paths phase, even if the inputs are changed to be propagated. I know you say this is related to yosys show in the commit message, can you elaborate on why these packages are necessary to have in the users environment? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPj2rBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xfbog/+IEgcaWo8mnj6zY6uN1a4HiLzXXMcb6DF O4q0IVYWpN3YH4TvFKmrROZ5A0yRr48ATnG3lrxX/WlAxwsPCxysflz4x3sITvP1 yfgyTsxW+i0Ep6BjkvCa6Sr7Gnb72imPU14nnKDLdaPhk3zA9KXY2aGQ8lpnvWMS Nq+/PyPVADzaTL6cwbzuoVYtCOaba6v9WoUepgMIPw4n9BgsTbKdEami5Uz4im3i 4nNTgchvT0WdZnTAZNUyIdMooeuAjdSTogaypDC7sXSJapMcCLZv1F9RsoinXh1B gwutVJnV3kmNnmRi4KV/I8YM8YruhR7zd5atyorXTEfLeGKxUhxIQtSRfRCGC4kx 86eDw5pRDVdjRZ9zTUSQ1MkBZGp0qcpk9Of6s/7HWgcVYDO0Z8gGRHG0ZTIzmh30 tIROonm5QhAFGAGNhfrbJGfkcS0ZiqVBoZQg/I4VByEuDxti4ZW7OCQ6Dtgm9xOP VIF05xj9p4X5NsD8N4o1ocxjhAM144YViQ2THYHqbarm/g9zVkTV+TTR5NbHmscz NA/KhYRAXKQN6cNUV84iarg6Vwt5gbmcIOYEZBf5WIUsadr+qWidguKw7atXz/uP Qik07oK3nJhR+6EPOKJM1LNHyjtNopG5HuF/qHtw+g9dOg4aoUOskNmsnPxedBSW bbZGdL89X/o= =rYkZ -----END PGP SIGNATURE----- --=-=-=--