From: "Ludovic Courtès" <ludo@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
Tobias Geerinckx-Rice <me@tobias.gr>,
Simon Tournier <zimon.toutoune@gmail.com>,
Mathieu Othacehe <othacehe@gnu.org>,
Christopher Baines <mail@cbaines.net>,
64188@debbugs.gnu.org, Ricardo Wurmus <rekado@elephly.net>
Subject: [bug#64188] [PATCH 0/8] More package tuning
Date: Sun, 25 Jun 2023 22:52:14 +0200 [thread overview]
Message-ID: <87352fz2m9.fsf_-_@gnu.org> (raw)
In-Reply-To: <f0435844501301f1850deffe64d3ac254007f4c3.1687247150.git.efraim@flashner.co.il> (Efraim Flashner's message of "Tue, 20 Jun 2023 10:51:07 +0300")
Efraim Flashner <efraim@flashner.co.il> skribis:
> * guix/transformations.scm (tuned-package)[build-system]: Don't replace
> the build-system if inheriting from the go-build-system.
> [arguments]: If using the go-build-system add a phase to set the
> micro-architecture for Go.
[...]
> @@ -570,14 +571,42 @@ (define (tuned-package p micro-architecture)
> (package
> (inherit p)
> (build-system
> - (build-system-with-tuning-compiler (package-build-system p)
> - micro-architecture))
> + ;; The go compiler doesn't need to be wrapped.
> + ;; XXX: This is where we check for supported micro-architectures.
> + (if (eq? (build-system-name (package-build-system p))
> + 'go)
> + (package-build-system p)
> + (build-system-with-tuning-compiler (package-build-system p)
> + micro-architecture)))
> (arguments
> ;; The machine building this package may or may not be able to run code
> ;; for MICRO-ARCHITECTURE. Because of that, skip tests; they are run for
> ;; the "baseline" variant anyway.
> (substitute-keyword-arguments (package-arguments p)
> - ((#:tests? _ #f) #f)))
> + ((#:tests? _ #f) #f)
> + ;; We add the tuning parameter after the default GO flags are set.
> + ((#:phases phases '%standard-phases)
> + (if (eq? (build-system-name (package-build-system p))
> + 'go)
> + #~(modify-phases #$phases
> + (add-after 'setup-go-environment 'set-microarchitecture
Can we use the same approach as before with
‘build-system-with-tuning-compiler’? That seems more robust to me and
it’d be more consistent.
Ludo’.
next prev parent reply other threads:[~2023-06-25 20:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 7:48 [bug#64188] [PATCH 0/8] More package tuning Efraim Flashner
2023-06-20 7:51 ` [bug#64188] [PATCH 1/8] gnu: %gcc-11-x86_64-micro-architectures: Add generic options Efraim Flashner
2023-06-25 20:49 ` [bug#64188] [PATCH 0/8] More package tuning Ludovic Courtès
2023-06-20 7:51 ` [bug#64188] [PATCH 2/8] guix: cpu: Add inexact CPU matching Efraim Flashner
2023-06-20 7:51 ` [bug#64188] [PATCH 3/8] guix: cpu: Rewrite fallback for x86_64 cpu->gcc-architecture Efraim Flashner
2023-06-20 7:51 ` [bug#64188] [PATCH 4/8] guix: cpu: Refactor cpu->gcc-architecture Efraim Flashner
2023-06-20 7:51 ` [bug#64188] [PATCH 5/8] gnu: go: Add CPU tuning targets Efraim Flashner
2023-06-20 7:51 ` [bug#64188] [PATCH 6/8] transformations: Allow tuning go packages Efraim Flashner
2023-06-25 20:52 ` Ludovic Courtès [this message]
2023-06-26 8:34 ` [bug#64188] [PATCH 0/8] More package tuning Efraim Flashner
2023-07-13 15:27 ` Ludovic Courtès
2023-07-17 12:02 ` Efraim Flashner
2023-07-17 15:41 ` Ludovic Courtès
2023-07-18 11:17 ` Efraim Flashner
2023-07-19 8:39 ` Josselin Poiret via Guix-patches via
2023-08-07 7:33 ` Ludovic Courtès
2023-08-21 16:54 ` bug#64188: " Ludovic Courtès
2023-06-20 7:51 ` [bug#64188] [PATCH 7/8] guix: cpu: Add gcc-architecture->generic-architecture mapping Efraim Flashner
2023-06-25 20:54 ` [bug#64188] [PATCH 0/8] More package tuning Ludovic Courtès
2023-06-26 8:34 ` Efraim Flashner
2023-06-20 7:51 ` [bug#64188] [PATCH 8/8] transformations: Allow autotuning for go packages Efraim Flashner
2023-06-25 20:47 ` [bug#64188] [PATCH 0/8] More package tuning Ludovic Courtès
2023-06-26 8:34 ` Efraim Flashner
2023-06-26 12:38 ` [bug#64188] [PATCH v2 0/7] " Efraim Flashner
2023-06-26 12:38 ` [bug#64188] [PATCH v2 1/7] gnu: %gcc-11-x86_64-micro-architectures: Add psabi entries Efraim Flashner
2023-06-26 12:38 ` [bug#64188] [PATCH v2 2/7] guix: cpu: Add generalized CPU matching Efraim Flashner
2023-06-26 12:38 ` [bug#64188] [PATCH v2 3/7] guix: cpu: Rewrite fallback for x86_64 cpu->gcc-architecture Efraim Flashner
2023-06-26 12:38 ` [bug#64188] [PATCH v2 4/7] guix: cpu: Refactor cpu->gcc-architecture Efraim Flashner
2023-06-26 12:38 ` [bug#64188] [PATCH v2 5/7] guix: cpu: Add gcc-architecture->micro-architecture-level mapping Efraim Flashner
2023-06-26 12:38 ` [bug#64188] [PATCH v2 6/7] gnu: go: Add CPU tuning targets Efraim Flashner
2023-06-26 12:38 ` [bug#64188] [PATCH v2 7/7] transformations: Allow tuning go packages Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87352fz2m9.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=64188@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=efraim@flashner.co.il \
--cc=mail@cbaines.net \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.