* [bug#68488] [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader.
@ 2024-01-15 21:57 Tomas Volf
2024-01-17 9:53 ` bug#68488: " Mathieu Othacehe
0 siblings, 1 reply; 2+ messages in thread
From: Tomas Volf @ 2024-01-15 21:57 UTC (permalink / raw)
To: 68488; +Cc: Tomas Volf
Without this change, trying to create a system image with efi-raw type while
using grub-efi-removable-bootloader fails with fairly confusing message:
EFI bootloader required with GPT partitioning
* gnu/system/image.scm (system-disk-image): Consider
grub-efi-removable-bootloader to be EFI bootloader.
Change-Id: I5f5e1a94e825fd29d6880c5bafb330e16a5ac962
---
gnu/system/image.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/system/image.scm b/gnu/system/image.scm
index 2cc1012893..5456b3a5a0 100644
--- a/gnu/system/image.scm
+++ b/gnu/system/image.scm
@@ -535,7 +535,8 @@ (define* (system-disk-image image
(when (and (gpt-image? image)
(not
- (memq (bootloader-name bootloader) '(grub-efi grub-efi32))))
+ (memq (bootloader-name bootloader)
+ '(grub-efi grub-efi32 grub-efi-removable-bootloader))))
(raise
(formatted-message
(G_ "EFI bootloader required with GPT partitioning"))))
base-commit: 31e736dac29e6f0ff8a2de3f28e210a68684ad21
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#68488: [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader.
2024-01-15 21:57 [bug#68488] [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader Tomas Volf
@ 2024-01-17 9:53 ` Mathieu Othacehe
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2024-01-17 9:53 UTC (permalink / raw)
To: Tomas Volf; +Cc: 68488-done
Hey,
> Without this change, trying to create a system image with efi-raw type while
> using grub-efi-removable-bootloader fails with fairly confusing message:
>
> EFI bootloader required with GPT partitioning
>
> * gnu/system/image.scm (system-disk-image): Consider
> grub-efi-removable-bootloader to be EFI bootloader.
Looks good, applied. I agree the error message is misleading. Would you
like to give a try at rewording it? The goal is to prevent the failing
combination GPT + non-EFI bootloader.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-17 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-15 21:57 [bug#68488] [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader Tomas Volf
2024-01-17 9:53 ` bug#68488: " Mathieu Othacehe
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.