From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: gmime: Remove gpg to gpg2 patch.
Date: Tue, 26 Jul 2016 14:35:56 +0200 [thread overview]
Message-ID: <871t2ga85v.fsf@gnu.org> (raw)
In-Reply-To: <20160725152110.GB20931@jasmine> (Leo Famulari's message of "Mon, 25 Jul 2016 11:21:10 -0400")
Leo Famulari <leo@famulari.name> skribis:
> On Mon, Jul 25, 2016 at 11:47:51AM +0000, ng0 wrote:
>> (with-fluids ((%default-port-encoding #f))
>> (substitute* (find-files "tests" "\\.c$")
>> (("(system *\\(\")(/[^ ]*)" all pre prog-path)
>> (let* ((base (basename prog-path))
>> - (prog (which (if (string=? base "gpg") "gpg2" base))))
>> + (prog (which base)))
>> (string-append pre
>> (or prog (error "not found: " base))))))))))))
>
> I can confirm this fixes the build failure. But, I don't fully
> understand the code that was changed. Can somebody double-check it?
LGTM. The comment above this hunk should also be changed.
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-07-26 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 11:47 [PATCH] gnu: gmime: Remove gpg to gpg2 patch ng0
2016-07-25 15:21 ` Leo Famulari
2016-07-26 12:35 ` Ludovic Courtès [this message]
2016-07-26 14:35 ` Andreas Enge
2016-07-26 23:59 ` Leo Famulari
2016-07-27 8:26 ` Andreas Enge
2016-07-26 17:48 ` Mark H Weaver
2016-07-26 23:44 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t2ga85v.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.