From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: gmime: Remove gpg to gpg2 patch. Date: Tue, 26 Jul 2016 14:35:56 +0200 Message-ID: <871t2ga85v.fsf@gnu.org> References: <878twqj5w8.fsf@we.make.ritual.n0.is> <20160725152110.GB20931@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS1ac-00005w-SI for guix-devel@gnu.org; Tue, 26 Jul 2016 08:36:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bS1aY-0007Jl-SK for guix-devel@gnu.org; Tue, 26 Jul 2016 08:36:02 -0400 In-Reply-To: <20160725152110.GB20931@jasmine> (Leo Famulari's message of "Mon, 25 Jul 2016 11:21:10 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > On Mon, Jul 25, 2016 at 11:47:51AM +0000, ng0 wrote: >> (with-fluids ((%default-port-encoding #f)) >> (substitute* (find-files "tests" "\\.c$") >> (("(system *\\(\")(/[^ ]*)" all pre prog-path) >> (let* ((base (basename prog-path)) >> - (prog (which (if (string=3D? base "gpg") "gpg2"= base)))) >> + (prog (which base))) >> (string-append pre >> (or prog (error "not found: " base)))= ))))))))) > > I can confirm this fixes the build failure. But, I don't fully > understand the code that was changed. Can somebody double-check it? LGTM. The comment above this hunk should also be changed. Thanks, Ludo=E2=80=99.