From: Marius Bakke <mbakke@fastmail.com>
To: Leo Famulari <leo@famulari.name>, 25177@debbugs.gnu.org
Subject: bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]
Date: Mon, 12 Dec 2016 00:04:38 +0100 [thread overview]
Message-ID: <871sxem5ix.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20161211223454.GA9474@jasmine>
[-- Attachment #1: Type: text/plain, Size: 2309 bytes --]
Leo Famulari <leo@famulari.name> writes:
> I noticed while building the package added by ng0's patch (below) that
> the test suite fails, but the check phase succeeds:
>
> [...]
> ======================================================================
> ERROR: test_clone_with_credentials (test.test_repository.CloneRepositoryTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/test/test_repository.py", line 544, in test_clone_with_credentials
> self._temp_dir, callbacks=pygit2.RemoteCallbacks(credentials=pygit2.UserPass("libgit2", "libgit2")))
> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/__init__.py", line 255, in clone_repository
> check_error(err)
> File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/errors.py", line 64, in check_error
> raise GitError(message)
> _pygit2.GitError: curl error: Couldn't resolve host 'bitbucket.org'
>
>
> ----------------------------------------------------------------------
> Ran 262 tests in 5.771s
>
> FAILED (errors=3)
> phase `check' succeeded after 8.9 seconds
> [...]
>
> Any ideas?
It looks like the 'check' phase ends with 'delete-file-recursively',
which has an unspecified return value, and that eventual failures from
'call-setuppy' are lost.
--8<---------------cut here---------------start------------->8---
(define* (check #:key tests? test-target use-setuptools? #:allow-other-keys)
"Run the test suite of a given Python package."
(if tests?
;; Running `setup.py test` creates an additional .egg-info directory in
;; build/lib in some cases, e.g. if the source is in a sub-directory
;; (given with `package_dir`). This will by copied to the output, too,
;; so we need to remove.
(let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
(call-setuppy test-target '() use-setuptools?)
(let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
(inter (lset-difference eqv? after before)))
(for-each delete-file-recursively inter)))
#t))
--8<---------------cut here---------------end--------------->8---
Perhaps something like this would work (untested)?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2016-12-11 23:05 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 18:12 [PATCH] Add pagure SCM/forge ng0
2016-12-11 18:12 ` [PATCH 01/11] gnu: Add python-flask-wtf ng0
2016-12-11 22:39 ` Leo Famulari
2016-12-11 23:05 ` ng0
2016-12-11 23:22 ` Leo Famulari
2016-12-12 10:27 ` Hartmut Goebel
2016-12-12 10:26 ` Hartmut Goebel
2016-12-11 18:12 ` [PATCH 02/11] gnu: Add python-flask-multistatic ng0
2016-12-11 22:40 ` Leo Famulari
2016-12-11 18:12 ` [PATCH 03/11] gnu: Add python-kitchen ng0
2016-12-11 22:44 ` Leo Famulari
2016-12-11 18:12 ` [PATCH 04/11] gnu: Add python-munch ng0
2016-12-11 18:12 ` [PATCH 05/11] gnu: Add python-pygit2 ng0
2016-12-11 22:34 ` bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.] Leo Famulari
2016-12-11 23:04 ` Marius Bakke [this message]
2016-12-11 23:05 ` Marius Bakke
2016-12-11 23:23 ` Leo Famulari
2016-12-11 23:34 ` Marius Bakke
2016-12-12 7:54 ` Marius Bakke
2016-12-12 15:44 ` Leo Famulari
2016-12-12 22:23 ` Hartmut Goebel
2016-12-13 9:34 ` Marius Bakke
2016-12-13 20:21 ` bug#25177: Test failures don't cause some Python packages to fail Marius Bakke
2016-12-13 22:11 ` Leo Famulari
2016-12-14 12:11 ` Marius Bakke
2016-12-15 9:26 ` Marius Bakke
2016-12-15 23:55 ` Leo Famulari
2016-12-16 14:02 ` Marius Bakke
2016-12-17 17:14 ` Leo Famulari
2016-12-17 17:38 ` Marius Bakke
2016-12-17 17:56 ` Leo Famulari
2016-12-17 20:15 ` Leo Famulari
2016-12-17 23:47 ` Marius Bakke
2016-12-18 1:28 ` Leo Famulari
2016-12-18 18:55 ` Marius Bakke
2016-12-18 19:04 ` Leo Famulari
2016-12-20 18:49 ` Marius Bakke
2016-12-20 19:30 ` Leo Famulari
2016-12-24 13:43 ` Marius Bakke
2016-12-24 16:26 ` Leo Famulari
2016-12-26 18:33 ` Leo Famulari
2016-12-16 9:23 ` Hartmut Goebel
2016-12-13 22:47 ` Removing the python-updates branch [was Re: bug#25177: Test failures don't cause some Python packages to fail] Leo Famulari
2016-12-11 18:12 ` [PATCH 06/11] gnu: Add python2-openid ng0
2016-12-11 18:12 ` [PATCH 07/11] gnu: Add python-openid-cla ng0
2016-12-11 18:12 ` [PATCH 08/11] gnu: Add python-openid-teams ng0
2016-12-11 18:12 ` [PATCH 09/11] gnu: Add python-straight.plugin ng0
2016-12-11 18:12 ` [PATCH 10/11] gnu: Add python-trollius-redis ng0
2016-12-11 18:12 ` [PATCH 11/11] gnu: Add pagure ng0
2016-12-11 18:48 ` ng0
2016-12-11 22:54 ` Leo Famulari
2016-12-13 22:05 ` Ricardo Wurmus
2016-12-11 22:52 ` [PATCH] Add pagure SCM/forge Leo Famulari
2016-12-12 9:21 ` ng0
2016-12-12 15:18 ` Leo Famulari
2016-12-14 12:25 ` [PATCH] series: Add pagure (v2) ng0
2016-12-14 12:25 ` [PATCH 01/11] gnu: Add python-flask-wtf ng0
2016-12-14 12:25 ` [PATCH 02/11] gnu: Add python-flask-multistatic ng0
2016-12-14 12:25 ` [PATCH 03/11] gnu: Add python-kitchen ng0
2016-12-14 12:25 ` [PATCH 04/11] gnu: Add python-munch ng0
2016-12-14 12:25 ` [PATCH 05/11] gnu: Add python-pygit2 ng0
2016-12-14 12:25 ` [PATCH 06/11] gnu: Add python2-openid ng0
2016-12-14 12:25 ` [PATCH 07/11] gnu: Add python-openid-cla ng0
2016-12-14 12:25 ` [PATCH 08/11] gnu: Add python-openid-teams ng0
2016-12-14 12:25 ` [PATCH 09/11] gnu: Add python-straight-plugin ng0
2016-12-14 12:25 ` [PATCH 10/11] gnu: Add python-trollius-redis ng0
2016-12-14 12:25 ` [PATCH 11/11] gnu: Add pagure ng0
2016-12-14 15:36 ` Leo Famulari
2016-12-14 16:27 ` ng0
2016-12-14 16:47 ` Leo Famulari
2016-12-19 9:07 ` Pagure dependencies, rebased (v3) ng0
2016-12-19 9:07 ` [PATCH 01/11] gnu: Add python-flask-wtf ng0
2016-12-20 23:10 ` Danny Milosavljevic
2016-12-21 11:47 ` Dependencies of pagure, revision of 2016-12-21 ng0
2016-12-21 11:47 ` [PATCH 01/11] gnu: Add python-flask-wtf ng0
2016-12-21 11:47 ` [PATCH 02/11] gnu: Add python-flask-multistatic ng0
2016-12-21 11:47 ` [PATCH 03/11] gnu: Add python-kitchen ng0
2016-12-21 11:47 ` [PATCH 04/11] gnu: Add python-munch ng0
2016-12-21 11:47 ` [PATCH 05/11] gnu: Add python-pygit2 ng0
2016-12-21 11:47 ` [PATCH 06/11] gnu: Add python2-openid ng0
2016-12-21 11:47 ` [PATCH 07/11] gnu: Add python-openid-cla ng0
2016-12-21 11:47 ` [PATCH 08/11] gnu: Add python-openid-teams ng0
2016-12-21 11:47 ` [PATCH 09/11] gnu: Add python-straight-plugin ng0
2016-12-21 11:47 ` [PATCH 10/11] gnu: Add python-trollius-redis ng0
2016-12-26 15:05 ` Dependencies of pagure, revision of 2016-12-21 ng0
2016-12-29 3:44 ` Leo Famulari
2016-12-29 12:19 ` ng0
2016-12-19 9:07 ` [PATCH 02/11] gnu: Add python-flask-multistatic ng0
2016-12-19 9:07 ` [PATCH 03/11] gnu: Add python-kitchen ng0
2016-12-19 9:07 ` [PATCH 04/11] gnu: Add python-munch ng0
2016-12-19 9:07 ` [PATCH 05/11] gnu: Add python-pygit2 ng0
2016-12-19 9:07 ` [PATCH 06/11] gnu: Add python2-openid ng0
2016-12-19 9:07 ` [PATCH 07/11] gnu: Add python-openid-cla ng0
2016-12-19 9:07 ` [PATCH 08/11] gnu: Add python-openid-teams ng0
2016-12-19 9:07 ` [PATCH 09/11] gnu: Add python-straight-plugin ng0
2016-12-19 9:07 ` [PATCH 10/11] gnu: Add python-trollius-redis ng0
2016-12-14 18:26 ` [PATCH 11/11] gnu: Add pagure ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sxem5ix.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=25177@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.