bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Leo Famulari <leo@famulari.name>]

I noticed while building the package added by ng0's patch (below) that
the test suite fails, but the check phase succeeds:

[...]
======================================================================
ERROR: test_clone_with_credentials (test.test_repository.CloneRepositoryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/test/test_repository.py", line 544, in test_clone_with_credentials
    self._temp_dir, callbacks=pygit2.RemoteCallbacks(credentials=pygit2.UserPass("libgit2", "libgit2")))
  File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/__init__.py", line 255, in clone_repository
    check_error(err)
  File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/errors.py", line 64, in check_error
    raise GitError(message)
_pygit2.GitError: curl error: Couldn't resolve host 'bitbucket.org'


----------------------------------------------------------------------
Ran 262 tests in 5.771s

FAILED (errors=3)
phase `check' succeeded after 8.9 seconds
[...]

Any ideas?

On Sun, Dec 11, 2016 at 06:12:31PM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-pygit2): New variable.
> ---
>  gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 2a49a060b..32f83deb4 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3376,6 +3376,36 @@ association studies (GWAS) on extremely large data sets.")
>  (define-public python2-numpy
>    (package-with-python2 python-numpy))
>  
> +(define-public python-pygit2
> +  (package
> +    (name "python-pygit2")
> +    (version "0.24.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/libgit2/"
> +                           "pygit2/archive/v" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1j7zkz2bsn4wqmkg1zkxb3r00xx28rkz9jdwcsikcl4ffa298xwa"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-six" ,python-six)
> +       ("python-cffi" ,python-cffi)
> +       ("libgit2" ,libgit2)
> +       ("python-tox" ,python-tox)))
> +    (home-page "http://github.com/libgit2/pygit2")
> +    (synopsis "Python bindings for libgit2")
> +    (description
> +     "Pygit2 is a set of Python bindings to the libgit2
> +shared library, libgit2 implements Git plumbing.")
> +    ;; GPL2.0 only, with linking exception.
> +    (license license:gpl2)))
> +
> +(define-public python2-pygit2
> +  (package-with-python2 python-pygit2))
> +
>  (define-public python-pyparsing
>    (package
>      (name "python-pyparsing")
> -- 
> 2.11.0
> 
>