From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org
Subject: Re: branch master updated: import/cran: Abort with error message when recursive import fails.
Date: Sat, 12 Dec 2020 12:21:29 +0100 [thread overview]
Message-ID: <871rfv46di.fsf@gnu.org> (raw)
In-Reply-To: <20201211231330.954.34915@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Fri, 11 Dec 2020 18:13:30 -0500")
Hi,
guix-commits@gnu.org skribis:
> commit 482b8ae2cd3f126a1300178e317df8993bf75b16
> Author: Ricardo Wurmus <rekado@elephly.net>
> AuthorDate: Sat Dec 12 00:06:18 2020 +0100
>
> import/cran: Abort with error message when recursive import fails.
>
> Previously, after a failed recursive import "guix import" would signal
> success.
>
> * guix/import/cran.scm (cran->guix-package): Raise a condition when all
> repositories have been exhausted.
> * guix/scripts/import/cran.scm (guix-import-cran): Handle errors.
[...]
> @@ -585,7 +586,10 @@ s-expression corresponding to that package, or #f on failure."
> ((bioconductor)
> ;; Retry import from CRAN
> (cran->guix-package package-name #:repo 'cran))
> - (else (values #f '()))))))))
> + (else
> + (raise (condition
> + (&message
> + (message "couldn't find meta-data for R package")))))))))))
Maybe include the package name?
(raise (formatted-message
(G_ "couldn't find meta-data for R package '~a'")
package-name))
Ludo’.
parent reply other threads:[~2020-12-12 11:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201211231330.954.34915@vcs0.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rfv46di.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.