From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IFS1Ndyn1F8ybAAA0tVLHw (envelope-from ) for ; Sat, 12 Dec 2020 11:22:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KCCQMdyn1F/vPgAA1q6Kng (envelope-from ) for ; Sat, 12 Dec 2020 11:22:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7E1539405D1 for ; Sat, 12 Dec 2020 11:21:54 +0000 (UTC) Received: from localhost ([::1]:35938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ko2yH-0006al-EL for larch@yhetil.org; Sat, 12 Dec 2020 06:21:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ko2xw-0006Xv-Em for guix-devel@gnu.org; Sat, 12 Dec 2020 06:21:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45293) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ko2xv-0001dG-Vn; Sat, 12 Dec 2020 06:21:31 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33892 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ko2xv-00062y-1Y; Sat, 12 Dec 2020 06:21:31 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-devel@gnu.org Subject: Re: branch master updated: import/cran: Abort with error message when recursive import fails. References: <20201211231330.954.34915@vcs0.savannah.gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Frimaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 12 Dec 2020 12:21:29 +0100 In-Reply-To: <20201211231330.954.34915@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Fri, 11 Dec 2020 18:13:30 -0500") Message-ID: <871rfv46di.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 7E1539405D1 X-Spam-Score: -1.30 X-Migadu-Scanner: scn1.migadu.com X-TUID: jNL/70cDP8U5 Hi, guix-commits@gnu.org skribis: > commit 482b8ae2cd3f126a1300178e317df8993bf75b16 > Author: Ricardo Wurmus > AuthorDate: Sat Dec 12 00:06:18 2020 +0100 > > import/cran: Abort with error message when recursive import fails. >=20=20=20=20=20 > Previously, after a failed recursive import "guix import" would signal > success. >=20=20=20=20=20 > * guix/import/cran.scm (cran->guix-package): Raise a condition when a= ll > repositories have been exhausted. > * guix/scripts/import/cran.scm (guix-import-cran): Handle errors. [...] > @@ -585,7 +586,10 @@ s-expression corresponding to that package, or #f on= failure." > ((bioconductor) > ;; Retry import from CRAN > (cran->guix-package package-name #:repo 'cran)) > - (else (values #f '())))))))) > + (else > + (raise (condition > + (&message > + (message "couldn't find meta-data for R package")= )))))))))) Maybe include the package name? (raise (formatted-message (G_ "couldn't find meta-data for R package '~a'") package-name)) Ludo=E2=80=99.