From: Simon Tournier <zimon.toutoune@gmail.com>
To: Bruno Victal <mirai@makinata.eu>, 61829@debbugs.gnu.org
Cc: Bruno Victal <mirai@makinata.eu>
Subject: [bug#61829] [PATCH 11/11] guix: packages: Remove 'origin-sha256' procedure.
Date: Tue, 28 Feb 2023 13:57:49 +0100 [thread overview]
Message-ID: <871qmaj6b6.fsf@gmail.com> (raw)
In-Reply-To: <b385682f37115c576fe85de408fe6f450f261d14.1677456515.git.mirai@makinata.eu>
Hi,
On lun., 27 févr. 2023 at 00:11, Bruno Victal <mirai@makinata.eu> wrote:
> - origin-sha256 ;deprecated
[...]
> -(define-deprecated (origin-sha256 origin)
> - origin-hash
> - (let ((hash (origin-hash origin)))
> - (unless (eq? (content-hash-algorithm hash) 'sha256)
> - (raise (condition (&message
> - (message (G_ "no SHA256 hash for origin"))))))
> - (content-hash-value hash)))
Similarly as previously, I would not remove this without more
advertisement.
> diff --git a/tests/import-utils.scm b/tests/import-utils.scm
> index 44dff14597..1565dd610a 100644
> --- a/tests/import-utils.scm
> +++ b/tests/import-utils.scm
> @@ -141,7 +141,7 @@ (define-module (test-import-utils)
> (license:license? (package-license pkg))
> (build-system? (package-build-system pkg))
> (origin? (package-source pkg))
> - (equal? (origin-sha256 (package-source pkg))
> + (equal? (content-hash-value (origin-hash (package-source pkg)))
This LGTM although this test was for testing origin-sha256 specifically,
I guess. :-)
Cheers,
simon
next prev parent reply other threads:[~2023-02-28 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 0:10 [bug#61829] [PATCH 00/11] Purge pre-1.3.0 deprecated procedures & variables Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 01/11] gnu: Purge pre-1.3.0 deprecated packages Bruno Victal
2023-02-28 12:52 ` Simon Tournier
2023-03-02 2:29 ` Bruno Victal
2023-03-03 16:29 ` [bug#61829] [PATCH 00/11] Purge pre-1.3.0 deprecated procedures & variables Ludovic Courtès
2023-03-03 18:57 ` [bug#61829] [PATCH 01/11] gnu: Purge pre-1.3.0 deprecated packages Simon Tournier
2023-02-27 0:11 ` [bug#61829] [PATCH 02/11] gnu: curl-minimal: Remove variable Bruno Victal
2023-02-28 12:54 ` Simon Tournier
2023-02-27 0:11 ` [bug#61829] [PATCH 03/11] services: ntp-service-type: Remove deprecated server as strings support Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 04/11] services: sddm: Remove 'sddm-service' procedure Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 05/11] services: base: Remove 'console-keymap-service-type' variable Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 06/11] services: base: Remove 'console-font-service' procedure Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 07/11] services: guix-publish: Remove 'compression-level' field Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 08/11] services: desktop: Remove 'gnome-desktop-service' procedure Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 09/11] services: desktop: Remove 'mate-desktop-service' procedure Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 10/11] services: desktop: Remove 'xfce-desktop-service' procedure Bruno Victal
2023-02-27 0:11 ` [bug#61829] [PATCH 11/11] guix: packages: Remove 'origin-sha256' procedure Bruno Victal
2023-02-28 12:57 ` Simon Tournier [this message]
2023-04-07 16:02 ` bug#61829: [PATCH 00/11] Purge pre-1.3.0 deprecated procedures & variables Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qmaj6b6.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=61829@debbugs.gnu.org \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.