From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MKLXD4MT/mNJnQAAbAwnHQ (envelope-from ) for ; Tue, 28 Feb 2023 15:45:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +JLiD4MT/mN1rgAAauVa8A (envelope-from ) for ; Tue, 28 Feb 2023 15:45:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C14C5A57 for ; Tue, 28 Feb 2023 15:45:23 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=leNHRdeJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677595523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=P43+8BKlzeRg/t0BSBiSI8kNuxiJhuqXJemBsNim5uU=; b=VbPqXoTTCGEmkJkWNMY3KuO4/HJGT2w5ivwzppGlkdPEJbs4z0oPZujJv6cd+cWnV7HfW4 qoK6RocOe36rUmyk9/5U3ffM9p+LcxpZO7jOmSVyjDbRoTNvfPx55u7mwMohKv0u7uAv+m M+B4rXryfvxOxSB2dCKqO3y55iOScf5QVPqLmeTXr3fUX29QmaQ/2nKEqUYglu+yT4Xrcj OBB6vji7oGK18ZBWEEgT1NpNkKgxCpITUP2br4Th1BqOCwwUCHoAyiScs+Fqu+NznQUeC/ 5Ps+kJsMfikA4RNi38xOXzYlyHT4N4jJUhonfgKJDugybPcihqR3+kpCJj3vMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=leNHRdeJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677595523; a=rsa-sha256; cv=none; b=NJerlmOboOvMsGvmmzCpJ2QmLpWte7raBp6CxukLxFElvKzQ7v3g/8wGX4/T4rymBnmyAS UGRva3eOrm6yemH6ix7R1UEVsdNDHYd4LoWmVK3SaX3PMs1EkCIzIi/SVYzpuqWnJBwJPR 9K41RqSXKIGnEVMkx+TXDk+NQwekJ5Zd7NedWeX1EH7AY3sKL834I6dpNj5Jz1P8bteSfz I0c+AYwCB2Iq60aIErj7yXyFSXv8Baj5UpEYxVojr7GUtCmEPmMQrBlMBVW9BZ+DAZUwY+ iZYeUV/yMbNKvBu60+NSCn6r2rhyKPmH7CY271Tw/BCR/kzyr3SXujv+ocuSEg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pX1E0-0001B9-Jv; Tue, 28 Feb 2023 09:45:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX1Dz-00017Y-11 for guix-patches@gnu.org; Tue, 28 Feb 2023 09:45:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pX1Dy-000838-Nm for guix-patches@gnu.org; Tue, 28 Feb 2023 09:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pX1Dy-0001eb-J2 for guix-patches@gnu.org; Tue, 28 Feb 2023 09:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61829] [PATCH 11/11] guix: packages: Remove 'origin-sha256' procedure. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Feb 2023 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61829 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal , 61829@debbugs.gnu.org Cc: Bruno Victal Received: via spool by 61829-submit@debbugs.gnu.org id=B61829.16775954436252 (code B ref 61829); Tue, 28 Feb 2023 14:45:02 +0000 Received: (at 61829) by debbugs.gnu.org; 28 Feb 2023 14:44:03 +0000 Received: from localhost ([127.0.0.1]:50032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX1D1-0001ck-9t for submit@debbugs.gnu.org; Tue, 28 Feb 2023 09:44:03 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:35372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX1Cs-0001bJ-9D for 61829@debbugs.gnu.org; Tue, 28 Feb 2023 09:43:54 -0500 Received: by mail-wm1-f45.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso6273400wmb.0 for <61829@debbugs.gnu.org>; Tue, 28 Feb 2023 06:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677595428; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=P43+8BKlzeRg/t0BSBiSI8kNuxiJhuqXJemBsNim5uU=; b=leNHRdeJPpheSH/09M2R/Cp2GY2/WWWu8T733xhBsEaWBBKOCm0fzVGy/45QXhG4io gcwlzKSVv8XjY4HrPkysUjlVZHjNTGOZUanW4aARkx4SFcqMb90PZsx0Zoa8gAGIT+Q4 PYmRgbOSsUBfmsGe/fUe+VKjh3WadK1UEFCIIbwi4mWkzbR7TMH5bBMM682WJ9x7wT4q LGRVj6qUlHHlQpTwcNlEUONLlTvtKkU/FleHM4nKpd61kVdOy+mwoEIz079XocRbZij8 USxV4IQIoDet7yLm4wVKNpLmi+H6eXSyLDLhcDeEq5MoTOuaEPcBhmCeuIXR1fO0HGNC 9CJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677595428; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P43+8BKlzeRg/t0BSBiSI8kNuxiJhuqXJemBsNim5uU=; b=LVgPk/xbL99L199oFlcjXnIRSgwNVF66lDTcr4SobOlc15HuSH7u8GKMLZf8dv3Ity Vbqxb3IdS7W5rqd9hEWNTS8s7mbkiQ0Qo1qsXvD6Tv31giRVe4o/wYcSgAICDnI09UJt mwZ21wzeqa+r6P0Oel8YMgugElASkmzfwm1JZRNUklmI5GBNg6z1cql/V22dSMLEk7Er dx6Iq+K/rN26vX3Cpo0XMA/uBPL5vwGVj2rHOHatVQniK2M3OIuNZf7PDcZMUw9LGDBF pHG5j8OFiP/gpYpEjggxwWMTenIH6Em+mJrs93aFweSjZDP+5OK1vbUJPIJ4WwBERFkq KR/A== X-Gm-Message-State: AO0yUKUJn/eROptwYX9/B6BBxsTIbcc45JR4qPxYE+xc9naCcMM+yvXO U05TYb/7j9WL4B9KDvdthE8= X-Google-Smtp-Source: AK7set9LZiZQoDB/N32HKzJ45eoVYXTxDiv5crkEz05cG4cXAv75guLbJ8Uv1AiqaKH91Y+dvqC1hA== X-Received: by 2002:a05:600c:1d01:b0:3e2:415:f09f with SMTP id l1-20020a05600c1d0100b003e20415f09fmr2563389wms.3.1677595428593; Tue, 28 Feb 2023 06:43:48 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id o18-20020a05600c4fd200b003eaf666cbe0sm13544366wmq.27.2023.02.28.06.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 06:43:48 -0800 (PST) From: Simon Tournier In-Reply-To: References: Date: Tue, 28 Feb 2023 13:57:49 +0100 Message-ID: <871qmaj6b6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Spam-Score: -2.89 X-Spam-Score: -2.89 X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 1C14C5A57 List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: dnO9IqgP2469 Hi, On lun., 27 f=C3=A9vr. 2023 at 00:11, Bruno Victal wrot= e: > - origin-sha256 ;deprecated [...] > -(define-deprecated (origin-sha256 origin) > - origin-hash > - (let ((hash (origin-hash origin))) > - (unless (eq? (content-hash-algorithm hash) 'sha256) > - (raise (condition (&message > - (message (G_ "no SHA256 hash for origin")))))) > - (content-hash-value hash))) Similarly as previously, I would not remove this without more advertisement. > diff --git a/tests/import-utils.scm b/tests/import-utils.scm > index 44dff14597..1565dd610a 100644 > --- a/tests/import-utils.scm > +++ b/tests/import-utils.scm > @@ -141,7 +141,7 @@ (define-module (test-import-utils) > (license:license? (package-license pkg)) > (build-system? (package-build-system pkg)) > (origin? (package-source pkg)) > - (equal? (origin-sha256 (package-source pkg)) > + (equal? (content-hash-value (origin-hash (package-source pkg))) This LGTM although this test was for testing origin-sha256 specifically, I guess. :-) Cheers, simon