From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rostislav Svoboda <rostislav.svoboda@gmail.com>
Cc: 62123@debbugs.gnu.org
Subject: [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel.
Date: Fri, 17 Mar 2023 09:51:54 +0100 [thread overview]
Message-ID: <871qlndal1.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAEtmmezZWwj5k1su3mwazHMJ9FYi=8CR99r9HdTgXpLzqkbLkw@mail.gmail.com> (Rostislav Svoboda's message of "Mon, 13 Mar 2023 14:01:52 +0100")
Hello,
Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:
> Oh, the patch is broken, ignore it. sorry. Here's a correction.
Thanks. Some comments follow.
> Please have a look at the 'python2 vs. python3' comment. Is it OK to
> make it work just for python3?
Guix does not support Python 2 anymore. Note, however,
that you can provide `python-wrapper' as input instead of `python', and
use "python" executable. Anyway sticking to "python3" is OK.
> + (inputs (list python))
> + (propagated-inputs (list emacs-dash emacs-s))
Nitpick: usually, inputs and propagated inputs are located after arguments.
> + (arguments
> + (list #:phases #~(modify-phases %standard-phases
You can add a newline characther after `list' and another one after
`#:phases'.
> + (add-after 'unpack 'substitute-python-path
> + (lambda* (#:key inputs #:allow-other-keys)
> + (emacs-substitute-variables "pippel.el"
> +
> ("pippel-python-command"
> + (search-input-file
> + inputs
> +;;; For 'python2 vs. python3' see the choice:
> +;;; https://github.com/arifer612/pippel/blob/cb194952ee150e77601d3233dabdb521b976ee79/pippel.el#L65
> +
> "/bin/python3"))))))))
> + (home-page "https://github.com/arifer612/pippel")
> + (synopsis "Emacs frontend to Python package manager pip")
pip -> Pip
> + (description
> + "Emacs frontend for the Python package manager pip. As pippel also uses
> +@code{tabulated-list-mode}, it provides a similar package menu like
> +@code{package-list-packages}.")
The first sentence is not complete : "Pippel is an Emacs…"
Also, pip -> Pip, pippel -> Pippel, @code{tabulated-list-mode} ->
Tabulated List mode.
> + (license license:gpl3+))))
I think you also need to include "pippel.py" file through #:include
keyword and possibly configure `pippel-package-path'.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-03-17 8:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 14:49 [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Rostislav Svoboda
2023-03-11 14:49 ` [bug#62121] [PATCH 2/4] gnu: Add emacs-railscasts-theme Rostislav Svoboda
2023-03-17 8:43 ` bug#62121: " Nicolas Goaziou
2023-03-27 19:17 ` [bug#62121] " Rostislav Svoboda
2023-03-30 10:39 ` Nicolas Goaziou
2023-03-11 14:49 ` [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel Rostislav Svoboda
2023-03-13 13:01 ` Rostislav Svoboda
2023-03-17 8:51 ` Nicolas Goaziou [this message]
2023-03-28 22:34 ` Rostislav Svoboda
2023-03-30 10:38 ` bug#62123: " Nicolas Goaziou
2023-03-11 14:49 ` [bug#62124] [PATCH 4/4] gnu: Add emacs-column-enforce-mode Rostislav Svoboda
2023-03-24 9:15 ` bug#62124: " Nicolas Goaziou
2023-03-17 8:36 ` [bug#62122] [PATCH 1/4] gnu: Add emacs-sphinx-doc Nicolas Goaziou
2023-03-27 19:17 ` Rostislav Svoboda
2023-03-30 16:21 ` bug#62122: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qlndal1.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=62123@debbugs.gnu.org \
--cc=rostislav.svoboda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.