From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YBYjB3YqFGRZaAAASxT56A (envelope-from ) for ; Fri, 17 Mar 2023 09:53:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MHEqB3YqFGRLNAEA9RJhRA (envelope-from ) for ; Fri, 17 Mar 2023 09:53:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD86AB0D0 for ; Fri, 17 Mar 2023 09:53:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd5pg-0003EV-Q6; Fri, 17 Mar 2023 04:53:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd5pe-0003Do-RZ for guix-patches@gnu.org; Fri, 17 Mar 2023 04:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pd5pe-0008IR-IT for guix-patches@gnu.org; Fri, 17 Mar 2023 04:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pd5pe-0008Uk-4a for guix-patches@gnu.org; Fri, 17 Mar 2023 04:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Mar 2023 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62123 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rostislav Svoboda Cc: 62123@debbugs.gnu.org Received: via spool by 62123-submit@debbugs.gnu.org id=B62123.167904312532590 (code B ref 62123); Fri, 17 Mar 2023 08:53:02 +0000 Received: (at 62123) by debbugs.gnu.org; 17 Mar 2023 08:52:05 +0000 Received: from localhost ([127.0.0.1]:43639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5oj-0008Ta-FT for submit@debbugs.gnu.org; Fri, 17 Mar 2023 04:52:05 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:51501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5oh-0008T3-Ay for 62123@debbugs.gnu.org; Fri, 17 Mar 2023 04:52:04 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 5AA7624000F; Fri, 17 Mar 2023 08:51:55 +0000 (UTC) From: Nicolas Goaziou References: <20230311144938.765-1-Rostislav.Svoboda@gmail.com> <20230311144938.765-3-Rostislav.Svoboda@gmail.com> Date: Fri, 17 Mar 2023 09:51:54 +0100 In-Reply-To: (Rostislav Svoboda's message of "Mon, 13 Mar 2023 14:01:52 +0100") Message-ID: <871qlndal1.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679043190; a=rsa-sha256; cv=none; b=lYrh0Fjk4Rhq9kYlKo7UzmykcMcrtSf1XmnyrE0RbBOtyD67ESp5hXMd0r2CRrzERmLyNW TAuGFg61379K7CPjWvnH8RNLhMN8pGv6UCRHn5HvB22UcBeQx729gx1HJGKg/Tr27Rll0N lyhYRX+p1VwqfhDepGAAnvNZh/vhc6hUMKCQphtOfHw1uIkfRCJfhclb9PjaWmgM7tshTz bELEAqrxgUx5UFOI5o8c9c4VA2XVDcM7Hc3bs0wB9R6cVjcjZQKmney0TgggIEXeSE4mCy KJq+K4KhgUYODhZw2Yn8q5BxaWHXGz55Y7H7j5HnQ6MZtG2Cv2ROZsqSjcn5BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679043190; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=+f6z209pWsiX3GS+sTM7WcAquHbnHUmOaRKWATcQ65g=; b=ivqbyvFIJtcVZwwdkb516u2gB49qeOjHfqDR0q20wITN5io+4Lif8GAhGIUIZa+j7qNPvY ZOAmJdWaVUzqLZ0Ux9SwCa7NbUUei5kXqjv7HDFZuP0kBYH5+UUCf2iiy+Fa3yRUv2Citn JPXzUUxCUWBX3wvgR/mx0MrK/cwdDOFUyqta2J8Pz6XnH+Uf3id1/SLQqxdB1X0kOW85vK y8MnfV4L9p6XNrf1zvujjvZ8kITGANA6gVXuCR/MViENzhV6cczqX/2ua9fGjT3ckYcAAN krBsBYyFXMUpNjf3YGpTewuJPb0pHdVorBYNuUf1LCXox8jPZezCGbQuSdUwKg== X-Migadu-Spam-Score: -3.34 X-Spam-Score: -3.34 X-Migadu-Queue-Id: CD86AB0D0 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: oF9RfoEPmUZ9 Hello, Rostislav Svoboda writes: > Oh, the patch is broken, ignore it. sorry. Here's a correction. Thanks. Some comments follow. > Please have a look at the 'python2 vs. python3' comment. Is it OK to > make it work just for python3? Guix does not support Python 2 anymore. Note, however, that you can provide `python-wrapper' as input instead of `python', and use "python" executable. Anyway sticking to "python3" is OK. > + (inputs (list python)) > + (propagated-inputs (list emacs-dash emacs-s)) Nitpick: usually, inputs and propagated inputs are located after arguments. > + (arguments > + (list #:phases #~(modify-phases %standard-phases You can add a newline characther after `list' and another one after `#:phases'. > + (add-after 'unpack 'substitute-python-path > + (lambda* (#:key inputs #:allow-other-keys) > + (emacs-substitute-variables "pippel.el" > + > ("pippel-python-command" > + (search-input= -file > + inputs > +;;; For 'python2 vs. python3' see the choice: > +;;; https://github.com/arifer612/pippel/blob/cb194952ee150e77601d3233dab= db521b976ee79/pippel.el#L65 > + > "/bin/python3")))))))) > + (home-page "https://github.com/arifer612/pippel") > + (synopsis "Emacs frontend to Python package manager pip") pip -> Pip > + (description > + "Emacs frontend for the Python package manager pip. As pippel al= so uses > +@code{tabulated-list-mode}, it provides a similar package menu like > +@code{package-list-packages}.") The first sentence is not complete : "Pippel is an Emacs=E2=80=A6" Also, pip -> Pip, pippel -> Pippel, @code{tabulated-list-mode} -> Tabulated List mode. > + (license license:gpl3+)))) I think you also need to include "pippel.py" file through #:include keyword and possibly configure `pippel-package-path'. Regards, --=20 Nicolas Goaziou