* [bug#68994] [PATCH] adding xmake
@ 2024-02-08 16:34 miro
2024-02-09 15:42 ` Mathieu Othacehe
0 siblings, 1 reply; 2+ messages in thread
From: miro @ 2024-02-08 16:34 UTC (permalink / raw)
To: 68994; +Cc: miro
---
gnu/packages/build-tools.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
index 15d88ded80..b6869524f0 100644
--- a/gnu/packages/build-tools.scm
+++ b/gnu/packages/build-tools.scm
@@ -15,6 +15,7 @@
;;; Copyright © 2021 qblade <qblade@protonmail.com>
;;; Copyright © 2021, 2023 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2022, 2023 Juliana Sims <juli@incana.org>
+;;; Copyright © 2024 Firat Yildirim <firat-23@hotmail.fr>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1013,3 +1014,24 @@ (define-public pdpmake
;; pdpmake is distributed under the public domain, but the sources include
;; tests under the GPL license version 2.
(license (list license:gpl2 license:public-domain))))
+
+(define-public xmake
+ (package
+ (name "xmake")
+ (version "2.8.6")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/xmake-io/xmake.git")
+ (recursive? #t)
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256 "1rz7f37rps5s81mylxrn04jpd4q17dfbmz0rrdxg1wybxnpgb8il")))
+ (arguments
+ `(#:tests? #f))
+ (build-system gnu-build-system)
+ (home-page "https://xmake.io/")
+ (synopsis "Cross-platform build utility based on Lua")
+ (description "Xmake is a cross-platform build utility based on Lua.")
+ (license gpl3+)))
base-commit: a903558577d249354aa74bbd6aab897235a7602b
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bug#68994] [PATCH] adding xmake
2024-02-08 16:34 [bug#68994] [PATCH] adding xmake miro
@ 2024-02-09 15:42 ` Mathieu Othacehe
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2024-02-09 15:42 UTC (permalink / raw)
To: miro; +Cc: 68994
Hello,
Thanks for this patch.
> ---
> gnu/packages/build-tools.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
You are missing a commit message here. The commit message should follow
the conventions explained here:
https://www.gnu.org/prep/standards/html_node/Change-Logs.html
You can also have a look the `git log` for examples.
> +(define-public xmake
> + (package
> + (name "xmake")
> + (version "2.8.6")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/xmake-io/xmake.git")
> + (recursive? #t)
^
that's a tabulation
Reported by `guix lint`:
gnu/packages/build-tools.scm:1027:0: xmake@2.8.6: tabulation on line 1027, column 0
> + (arguments
> + `(#:tests? #f))
There is a test directory so the tests should not be disabled.
> + (home-page "https://xmake.io/")
`guix lint` reports that:
gnu/packages/build-tools.scm:1023:5: xmake@2.8.6: permanent redirect
from https://github.com/xmake-io/xmake.git to
https://github.com/xmake-io/xmake
> + (synopsis "Cross-platform build utility based on Lua")
> + (description "Xmake is a cross-platform build utility based on Lua.")
Please expand a bit on that description. What are the features of xmake
for instance?
> + (license gpl3+)))
There's an issue preventing this from compiling. You should use
licence:gpl3+. By the way, it seems to be license:asl2.0 rather than
license:gplv3+.
Please make sure that `make` reports no error on your package.
Don't hesitate to ask if some remarks are unclear :)
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-09 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-08 16:34 [bug#68994] [PATCH] adding xmake miro
2024-02-09 15:42 ` Mathieu Othacehe
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.