From: Sarah Morgensen <iskarian@mgsn.dev>
To: Alexandru-Sergiu Marton <brown121407@posteo.ro>
Cc: 50740@debbugs.gnu.org
Subject: [bug#50740] [PATCH] gnu: Add wmname.
Date: Wed, 22 Sep 2021 16:42:09 -0700 [thread overview]
Message-ID: <86sfxww52m.fsf@mgsn.dev> (raw)
In-Reply-To: <20210922162831.24051-1-brown121407@posteo.ro> (Alexandru-Sergiu Marton's message of "Wed, 22 Sep 2021 16:28:31 +0000 (6 hours, 18 minutes, 15 seconds ago)")
Hello,
Thanks for your patch. I have a couple small suggestions, but otherwise it looks
good to me!
Alexandru-Sergiu Marton <brown121407@posteo.ro> writes:
> * gnu/packages/suckless.scm (wmname): New variable.
> ---
> gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index b24eced379..314d8d5e44 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -488,6 +488,36 @@ few minutes.")
> (home-page "https://tools.suckless.org/sent")
> (license license:x11)))
>
> +(define-public wmname
> + (package
> + (name "wmname")
> + (version "0.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://dl.suckless.org/tools/wmname-"
> + version ".tar.gz"))
> + (sha256
> + (base32 "1i82ilhbk36hspc2j0fbpg27wjj7xnvzpv1ppgf6fccina4d36jm"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f
Please always comment "#:tests? #f", even if it's just "no test
suite"/"no tests".
> + #:make-flags
> + (list (string-append "CC=" ,(cc-for-target))
> + (string-append "PREFIX=" %output))
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)))) ; No configure script
> + (inputs
> + `(("libx11" ,libx11)))
> + (home-page "https://tools.suckless.org/x/wmname/")
> + (synopsis "Print or set the window manager name")
> + (description "wmname prints/sets the window manager name property of the
> +root window similar to how hostname(1) behaves. It is useful for fixing
> +problems with JDK versions and other broken programs assuming a reparenting
> +window manager for instance.")
Consider:
(description "@command{wmname} prints/sets the window manager name
property of the root window, similar to how @command{hostname} behaves. It is
useful for fixing problems with JDK versions and other broken programs, such
as those which assume a reparenting window manager.")
> + (license license:x11)))
Though the license header *says* "MIT/X Consortium", the actual license
text looks like expat to me [0].
* Package review checklist (WIP)
Lack of a check is not proof of noncompliance.
1. [ ] Package builds (guix build package)
[X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le
[ ] i686 [ ] i586 [ ] mips64le
2. [ ] Build is reproducible (guix build --rounds=n package)
3. [ ] Tests enabled (if available) or disabled with in-source comment
4. [ ] No extraneous dependencies (guix size package)
5. [ ] No unnecessary pre-built binaries/blobs
6. [ ] Dependencies unvendored when available in Guix
7. [ ] Cross-compile friendly (cc-for-target, patches with inputs)
8. [ ] License matches source
9. [ ] No problematic lints (guix lint package)
10. [ ] Formatting follows guidelines
- [ ] Lines wrap at 80 characters
- [ ] Indentation passes etc/indent-code.el
- [ ] Two spaces used between sentences
For new packages:
1. [ ] Source url is robust
* mirror:// used with url-fetch when possible
* No auto-generated archives from source repo (prefer cloning)
2. [ ] Synopsis is short, descriptive, and meaningful to a wide audience
3. [ ] Description is objective, takes 5-10 lines, uses full sentences,
and provides the information users need to decide whether the
software fits their needs.
[0] https://en.wikipedia.org/wiki/MIT_License
--
Sarah
next prev parent reply other threads:[~2021-09-22 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 16:28 [bug#50740] [PATCH] gnu: Add wmname Alexandru-Sergiu Marton
2021-09-22 23:42 ` Sarah Morgensen [this message]
2021-09-22 23:50 ` Sarah Morgensen
2021-09-23 14:16 ` Alexandru-Sergiu Marton
2021-09-28 20:17 ` [bug#50740] [PATCH v2] " Alexandru-Sergiu Marton
2021-09-29 1:23 ` Sarah Morgensen
2021-10-13 8:45 ` bug#50740: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sfxww52m.fsf@mgsn.dev \
--to=iskarian@mgsn.dev \
--cc=50740@debbugs.gnu.org \
--cc=brown121407@posteo.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.