From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eOwaOpK/S2E/1gAAgWs5BA (envelope-from ) for ; Thu, 23 Sep 2021 01:43:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oMKtNZK/S2FoPQAAbx9fmQ (envelope-from ) for ; Wed, 22 Sep 2021 23:43:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C9B516F47 for ; Thu, 23 Sep 2021 01:43:14 +0200 (CEST) Received: from localhost ([::1]:41976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTBtR-0001o0-Co for larch@yhetil.org; Wed, 22 Sep 2021 19:43:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTBtG-0001nr-2d for guix-patches@gnu.org; Wed, 22 Sep 2021 19:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTBtF-0003Hw-Qj for guix-patches@gnu.org; Wed, 22 Sep 2021 19:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTBtF-0004Wb-Kj for guix-patches@gnu.org; Wed, 22 Sep 2021 19:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50740] [PATCH] gnu: Add wmname. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Sep 2021 23:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50740 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandru-Sergiu Marton Cc: 50740@debbugs.gnu.org Received: via spool by 50740-submit@debbugs.gnu.org id=B50740.163235413917331 (code B ref 50740); Wed, 22 Sep 2021 23:43:01 +0000 Received: (at 50740) by debbugs.gnu.org; 22 Sep 2021 23:42:19 +0000 Received: from localhost ([127.0.0.1]:52175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTBsZ-0004VT-50 for submit@debbugs.gnu.org; Wed, 22 Sep 2021 19:42:19 -0400 Received: from out1.migadu.com ([91.121.223.63]:29302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTBsU-0004VG-5m for 50740@debbugs.gnu.org; Wed, 22 Sep 2021 19:42:18 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632354132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NgMLjlblca2iSMkCpchAmbOKXrBgZaVd8GeUX4hwqCs=; b=LyrrXtF0aMkaxUR/nXTK96WXUnNX2o0nH9mnrbUH1Re4Nw28Fu7JBcseSuilKUaLjT86ow RaniXWsaeU7xuuvgiiMVlw8ekC9hKW63IfTorxZ1hKUSTO2DA1RfhjuU4IPBXdx/N/N5bn u3kMdU9AQRMA6v3ykk5x2GML8I1mYnw= From: Sarah Morgensen References: <20210922162831.24051-1-brown121407@posteo.ro> Date: Wed, 22 Sep 2021 16:42:09 -0700 In-Reply-To: <20210922162831.24051-1-brown121407@posteo.ro> (Alexandru-Sergiu Marton's message of "Wed, 22 Sep 2021 16:28:31 +0000 (6 hours, 18 minutes, 15 seconds ago)") Message-ID: <86sfxww52m.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632354194; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=NgMLjlblca2iSMkCpchAmbOKXrBgZaVd8GeUX4hwqCs=; b=WyNL4JqI1gyFyIAV3fcMiXYOWZ9VbI4FM+LZQxRba+WAEZGhG3StPcJzJW3vX/TPgd9JRF 2S0X8k6YWFkduaUUi7hLMsaZccsaZc6NFFAfZlOu0p6cgghe3XxQmSwe0ekmfLrlrNqqko UoSEKc3gT2bXx5V0vNuqnsv1mIjASfQglD9K/XiebK0nVoPNj/WLbyEed6PTlp3QipgkKd 0Y2c3TqKNv9H/jFRqBTSRnNT4ujpDUY8UZlfMSCdlVcTyDRvW86iOZkuxxFYphjefwg+8f TLNXk1YDZ0sp6dgC5Wg8rvuETMcpdGg66X6KocHnlLlzQcSxyVyPC9zNtKZJAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632354194; a=rsa-sha256; cv=none; b=lDqKHT5wPf3hK6k8yy3xMqWkGtzGLjMJGcBjVdjHMc/Ac+qMsmaamesG58l1qd6tDBM8os D/ljWWqGWEmHf961ZiTbnMrmkCB/YNWB8UWIqTE8ocgChVxHLxfsl/bHStAl50QvXuM/Rp pFohqWp2O6xSroxf7VQffL7yAAzsExfsLv0ldngDjqqmGOAcG7KUOPQ1jVntDCsm4OuLZ+ AsNRBjakifFpKOhl5gsxZlO1FLWiDJWYDJrm/PqodJgMPrZrvrVFLLCY4uKbBOElpOljDb YZFgSxN+iySKF3npUZ9L5S/OV8+9kPZDMbHSHLrY1goMpGspKnHTAtR7stQ/ew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=LyrrXtF0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=LyrrXtF0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3C9B516F47 X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: V7CbNtbezYlg Hello, Thanks for your patch. I have a couple small suggestions, but otherwise it looks good to me! Alexandru-Sergiu Marton writes: > * gnu/packages/suckless.scm (wmname): New variable. > --- > gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm > index b24eced379..314d8d5e44 100644 > --- a/gnu/packages/suckless.scm > +++ b/gnu/packages/suckless.scm > @@ -488,6 +488,36 @@ few minutes.") > (home-page "https://tools.suckless.org/sent") > (license license:x11))) > > +(define-public wmname > + (package > + (name "wmname") > + (version "0.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://dl.suckless.org/tools/wmname-" > + version ".tar.gz")) > + (sha256 > + (base32 "1i82ilhbk36hspc2j0fbpg27wjj7xnvzpv1ppgf6fccina4d36jm")))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f Please always comment "#:tests? #f", even if it's just "no test suite"/"no tests". > + #:make-flags > + (list (string-append "CC=" ,(cc-for-target)) > + (string-append "PREFIX=" %output)) > + #:phases > + (modify-phases %standard-phases > + (delete 'configure)))) ; No configure script > + (inputs > + `(("libx11" ,libx11))) > + (home-page "https://tools.suckless.org/x/wmname/") > + (synopsis "Print or set the window manager name") > + (description "wmname prints/sets the window manager name property of the > +root window similar to how hostname(1) behaves. It is useful for fixing > +problems with JDK versions and other broken programs assuming a reparenting > +window manager for instance.") Consider: (description "@command{wmname} prints/sets the window manager name property of the root window, similar to how @command{hostname} behaves. It is useful for fixing problems with JDK versions and other broken programs, such as those which assume a reparenting window manager.") > + (license license:x11))) Though the license header *says* "MIT/X Consortium", the actual license text looks like expat to me [0]. * Package review checklist (WIP) Lack of a check is not proof of noncompliance. 1. [ ] Package builds (guix build package) [X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le [ ] i686 [ ] i586 [ ] mips64le 2. [ ] Build is reproducible (guix build --rounds=n package) 3. [ ] Tests enabled (if available) or disabled with in-source comment 4. [ ] No extraneous dependencies (guix size package) 5. [ ] No unnecessary pre-built binaries/blobs 6. [ ] Dependencies unvendored when available in Guix 7. [ ] Cross-compile friendly (cc-for-target, patches with inputs) 8. [ ] License matches source 9. [ ] No problematic lints (guix lint package) 10. [ ] Formatting follows guidelines - [ ] Lines wrap at 80 characters - [ ] Indentation passes etc/indent-code.el - [ ] Two spaces used between sentences For new packages: 1. [ ] Source url is robust * mirror:// used with url-fetch when possible * No auto-generated archives from source repo (prefer cloning) 2. [ ] Synopsis is short, descriptive, and meaningful to a wide audience 3. [ ] Description is objective, takes 5-10 lines, uses full sentences, and provides the information users need to decide whether the software fits their needs. [0] https://en.wikipedia.org/wiki/MIT_License -- Sarah