From: zimoun <zimon.toutoune@gmail.com>
To: Gerd Heber <gerd.heber@gmail.com>, 46830@debbugs.gnu.org
Cc: Gerd Heber <gheber@hdfgroup.org>
Subject: [bug#46830] [PATCH Added hdf5-1.12-parallel-openmpi] * gnu/packages/maths.scm (hdf5-1.12-parallel-openmpi): New package based on HDF5 1.12.0
Date: Mon, 01 Mar 2021 11:41:01 +0100 [thread overview]
Message-ID: <86im6b9mwy.fsf@gmail.com> (raw)
In-Reply-To: <20210228133314.22935-1-gheber@hdfgroup.org>
Hi,
On Sun, 28 Feb 2021 at 07:33, Gerd Heber <gerd.heber@gmail.com> wrote:
> +(define-public hdf5-1.12-parallel-openmpi
> + (package/inherit hdf5-1.12
> + (name "hdf5-1.12-parallel-openmpi")
> + (inputs
> + `(("mpi" ,openmpi)
> + ,@(package-inputs hdf5)))
> + (arguments
> + (substitute-keyword-arguments (package-arguments hdf5)
> + ((#:configure-flags flags)
> + ``("--enable-parallel"
> + ,@(delete "--enable-cxx"
> + (delete "--enable-threadsafe" ,flags))))
> + ((#:phases phases)
> + `(modify-phases ,phases
> + (add-after 'build 'mpi-setup
> + ,%openmpi-setup)
> + (add-before 'check 'patch-tests
> + (lambda _
> + ;; OpenMPI's mpirun will exit with non-zero status if it
> + ;; detects an "abnormal termination", i.e. any process not
> + ;; calling MPI_Finalize(). Since the test is explicitly
> + ;; avoiding MPI_Finalize so as not to have at_exit and thus
> + ;; H5C_flush_cache from being called, mpirun will always
> + ;; complain, so turn this test off.
> + (substitute* "testpar/Makefile"
> + (("(^TEST_PROG_PARA.*)t_pflush1(.*)" front back)
> + (string-append front back "\n")))
> + (substitute* "tools/test/h5diff/testph5diff.sh"
> + (("/bin/sh") (which "sh")))
> + #t))))))
> + (synopsis "Management suite for data with parallel IO support")))
> +
Why duplicates? Something like:
--8<---------------cut here---------------start------------->8---
(define-public hdf5-1.12-parallel-openmpi
(package/inherit hdf5-parallel-openmpi
(version (package-version hdf5-1.12))
(source (package-source hdf5-1.12)))
--8<---------------cut here---------------end--------------->8---
seems simpler.
All the best,
simon
next prev parent reply other threads:[~2021-03-01 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 13:33 [bug#46830] [PATCH Added hdf5-1.12-parallel-openmpi] * gnu/packages/maths.scm (hdf5-1.12-parallel-openmpi): New package based on HDF5 1.12.0 Gerd Heber
2021-02-28 22:42 ` Gerd Heber via web
2021-03-01 10:41 ` zimoun [this message]
[not found] ` <CANnLdWFK--F3vTC7R6WtUMYOKA-MAJCWj6LXS42mv-ZNKF63YA@mail.gmail.com>
2021-03-02 9:41 ` zimoun
2021-03-02 19:39 ` Ludovic Courtès
2021-03-03 14:10 ` Gerd Heber
2021-03-05 1:08 ` zimoun
2021-03-08 14:01 ` Ludovic Courtès
2023-09-13 9:29 ` bug#46830: Closing Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86im6b9mwy.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=46830@debbugs.gnu.org \
--cc=gerd.heber@gmail.com \
--cc=gheber@hdfgroup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.