* [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests.
@ 2023-07-10 18:06 David Elsing
2023-07-14 2:33 ` Bruno Victal
0 siblings, 1 reply; 4+ messages in thread
From: David Elsing @ 2023-07-10 18:06 UTC (permalink / raw)
To: 64559; +Cc: David Elsing, andreas, efraim, bavier
* gnu/packages/chemistry.scm (freesasa)[arguments]: Add
"CFLAGS=-fno-builtin-malloc" to #:configure-flags.
---
gnu/packages/chemistry.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/chemistry.scm b/gnu/packages/chemistry.scm
index cddccf8aea..431b845989 100644
--- a/gnu/packages/chemistry.scm
+++ b/gnu/packages/chemistry.scm
@@ -703,7 +703,11 @@ (define-public freesasa
#~(list "--enable-check"
"--enable-parser-generator"
"CXXFLAGS=-std=c++17"
- "--enable-doxygen")
+ "--enable-doxygen"
+ ;; Some tests rely on replacing malloc with a wrapper which
+ ;; fails in a controlled way, but this does not work if the call
+ ;; is replaced.
+ "CFLAGS=-fno-builtin-malloc")
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'remove-libc++-linking
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests.
2023-07-10 18:06 [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests David Elsing
@ 2023-07-14 2:33 ` Bruno Victal
2023-07-14 23:01 ` David Elsing
0 siblings, 1 reply; 4+ messages in thread
From: Bruno Victal @ 2023-07-14 2:33 UTC (permalink / raw)
To: David Elsing; +Cc: andreas, efraim, 64559, bavier
Hi David,
On 2023-07-10 19:06, David Elsing wrote:
> + ;; Some tests rely on replacing malloc with a wrapper which
> + ;; fails in a controlled way, but this does not work if the call
> + ;; is replaced.
> + "CFLAGS=-fno-builtin-malloc")
Have you filed an issue with upstream regarding this?
It looks to me that this is something that should be figured out by the
build system or the unit tests.
--
Furthermore, I consider that nonfree software must be eradicated.
Cheers,
Bruno.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-14 19:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-10 18:06 [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests David Elsing
2023-07-14 2:33 ` Bruno Victal
2023-07-14 23:01 ` David Elsing
2024-02-14 19:20 ` David Elsing
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.