From: zimoun <zimon.toutoune@gmail.com>
To: Christopher Baines <mail@cbaines.net>, 59513@debbugs.gnu.org
Subject: [bug#59513] [PATCH v2] doc: contributing: Tweak the Commit Policy.
Date: Thu, 05 Jan 2023 10:12:49 +0100 [thread overview]
Message-ID: <868rih9wfi.fsf@gmail.com> (raw)
In-Reply-To: <20221208112051.5019-1-mail@cbaines.net>
Hi,
On Thu, 08 Dec 2022 at 11:20, Christopher Baines <mail@cbaines.net> wrote:
> Add more examples of when it can be appropriate to push changes without
> review, as I think this can be appropriate in the case of trivial changes (as
> mentioned before), but also non-trivial fixes.
This would be part of the commit message, right?
I would avoid the personal “I think” since it is a collective thought
with some consensus (I guess). For instance,
--8<---------------cut here---------------start------------->8---
Add more examples of when it can be appropriate to push changes without
review, as in the case of trivial changes (as mentioned before), but
also non-trivial fixes.
--8<---------------cut here---------------end--------------->8---
> No longer suggest pushing simple new packages or package upgrades (that don't
> cause lots of rebuilds) without sending to guix-patches. Now there's some
> automation for testing changes sent to guix-patches, sending changes there
> before pushing can mean that more rigerious testing takes place and help speed
--^
typo
s/rigerious/rigorous
> +Changes should be posted to @email{guix-patches@@gnu.org}. This mailing
> +list fills the patch-tracking database (@pxref{Tracking Bugs and
> +Patches}). It also allows patches to be picked up and tested by the
> +quality assurance tooling; the result of that testing eventually shows
> +up on the dashboard at
> +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where
> +@var{number} is the number assigned by the issue tracker. Leave time
To be consistent with (guix) Sending a Patch Series [1], I suggest to
use @var{ISSUE_NUMBER} instead of simply @var{number}.
1: <https://guix.gnu.org/manual/devel/en/guix.html#Sending-a-Patch-Series>
Aside the minor comments, all LGTM! This change appears to me a great
improvement, hoping it will reduce the number of red bullets in
dashboard [2].
2: <https://ci.guix.gnu.org/eval/91795/dashboard>
Cheers,
simon
next prev parent reply other threads:[~2023-01-05 10:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 10:49 [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy Christopher Baines
2022-11-23 20:27 ` zimoun
2022-11-24 8:40 ` Christopher Baines
2022-11-24 11:59 ` zimoun
2022-11-28 11:46 ` Christopher Baines
2022-12-02 9:45 ` Ludovic Courtès
2022-12-01 21:44 ` Ludovic Courtès
2022-12-12 10:33 ` Christopher Baines
2022-12-12 11:47 ` Ludovic Courtès
2022-12-08 11:20 ` [bug#59513] [PATCH v2] " Christopher Baines
2022-12-08 13:53 ` Liliana Marie Prikler
2022-12-12 10:49 ` Christopher Baines
2022-12-12 20:27 ` Liliana Marie Prikler
2022-12-13 14:06 ` Christopher Baines
2022-12-14 0:54 ` Vagrant Cascadian
2022-12-14 10:21 ` Christopher Baines
2022-12-20 10:55 ` Ludovic Courtès
2022-12-17 5:01 ` [bug#59513] [PATCH] " Maxim Cournoyer
2023-01-05 9:12 ` zimoun [this message]
2023-01-11 10:48 ` [bug#59513] [PATCH v2] " Christopher Baines
2023-01-11 10:50 ` bug#59513: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868rih9wfi.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=59513@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.