From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YJb2AxSitmMcXQEAbAwnHQ (envelope-from ) for ; Thu, 05 Jan 2023 11:10:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gB8CBBSitmMyfQEA9RJhRA (envelope-from ) for ; Thu, 05 Jan 2023 11:10:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4ACBD258 for ; Thu, 5 Jan 2023 11:10:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDNCI-0005kF-0L; Thu, 05 Jan 2023 05:10:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDNCG-0005jp-SR for guix-patches@gnu.org; Thu, 05 Jan 2023 05:10:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDNCF-0005gk-1B for guix-patches@gnu.org; Thu, 05 Jan 2023 05:10:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDNCE-0005PY-HZ for guix-patches@gnu.org; Thu, 05 Jan 2023 05:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH v2] doc: contributing: Tweak the Commit Policy. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Jan 2023 10:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Christopher Baines , 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.167291334320701 (code B ref 59513); Thu, 05 Jan 2023 10:10:02 +0000 Received: (at 59513) by debbugs.gnu.org; 5 Jan 2023 10:09:03 +0000 Received: from localhost ([127.0.0.1]:50339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDNBH-0005Np-4N for submit@debbugs.gnu.org; Thu, 05 Jan 2023 05:09:03 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:38498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDNBE-0005NI-Fv for 59513@debbugs.gnu.org; Thu, 05 Jan 2023 05:09:00 -0500 Received: by mail-wm1-f52.google.com with SMTP id fm16-20020a05600c0c1000b003d96fb976efso916200wmb.3 for <59513@debbugs.gnu.org>; Thu, 05 Jan 2023 02:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=9GUJ/0ihFpj2roedif1DmfGOgBZkQ72X6uJoEOcw9hk=; b=iNCveCeKIuYt80xldjIpgVQq7NW+dh0JqLfIyh+8nFDXut6OkZ4JLl1iA530vR6lO6 Qd6ge3F2KDdVNcghkR0NuGSAD4izlFUKkHnDbDnINFrT2G57S1HewiwYAmRvgU8GoHxM w4Ah18vzP24rG2BDLb2qpc6V+Gm28XcfU0hQvZ6KaLaW3w1drbR8N2qcFbgAHTTGCMx2 KbkLDncFdWvwkqbdMDZwjln62rG3jZu9+Evu3B7zeRXnUUinKFbRXu7yE0gPPdlL4sPh CB5gaKAywy3oh0gVDKh4tfnAE2CKyw1v//bo+rwOPIgswNSqcC+ixPBCxWLfWIYdt8hm mgVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9GUJ/0ihFpj2roedif1DmfGOgBZkQ72X6uJoEOcw9hk=; b=tpNQZUNY0jbZGN5Prwdj+fSdQCEaBSGk/b5GIYu5pzLhkb4xLd/yndalTwWw+TIxPI 0uidv3TjzXZAqYI5sklgUNorFwMFPwemJQ/GJpcgR5FfZswz+CF+gh9OZ3B59+gZrx/Z YxMvtkuimcGZQysM1Qq/gpQaIdkRIV6uwzCf6Tz9INJdCPDw6wppnVC60jV3GHdfIITN iCG9soLlVNB3yNNWHyVq/+qGWOCArROphAWY2nLvs+Hdv93fI6AOkb+WY2B5SEDdNQEJ fUXNt2NJuPf4RDf5eDQrsHaOvgdYMz4x6GjzSqghvMCZRB7GaO6p+r+PX8uTqWjMOnwR XyWw== X-Gm-Message-State: AFqh2kr/wKp6H9+tvMgDW7lBpigbq31piAdP1oPePX7rzRPGHakXYxFw Q7uAiWXt73zPCRSK6qta6PZoW9h02D8= X-Google-Smtp-Source: AMrXdXvXA7WJJmxCiT+1j35HJG3gIziGDJ1ELufaE4OjHPW7wB6mmpJqqPKYRzQvByBd+JGcnnf/JQ== X-Received: by 2002:a05:600c:1c28:b0:3d1:efa0:2b30 with SMTP id j40-20020a05600c1c2800b003d1efa02b30mr9093666wms.3.1672913334278; Thu, 05 Jan 2023 02:08:54 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id hg9-20020a05600c538900b003cfa622a18asm1874280wmb.3.2023.01.05.02.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 02:08:53 -0800 (PST) From: zimoun In-Reply-To: <20221208112051.5019-1-mail@cbaines.net> References: <20221123104946.29480-1-mail@cbaines.net> <20221208112051.5019-1-mail@cbaines.net> Date: Thu, 05 Jan 2023 10:12:49 +0100 Message-ID: <868rih9wfi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672913427; a=rsa-sha256; cv=none; b=jAIy9vCdxIfaCJIFq9mm74cynxA4j9q4QYi9FM89QfRy2a66H/GTSupZynZQ4AYEGf1lUu 2ouhxW4Vtkhr8q6m8qjeAJ7S6sZGMuS1Bc0zcQgVBsUa+zyg2plhF22kgS3pPG2phK9Tiu 6RH0Nj73U7pIEfNtbSEqyiQkKWMUKN3+EgM9Hhj7ozLfoHK5OS1aEkt5pABjMQHW/tVxF1 Te3O3kmxsYyoGiPi5X9V8GIt2A1rdtdH8R3ouv/enrYtS3dBy449NT1pIEOpTQP9rNYdLJ +WIit0IMmH65HT2r5D6TsoXcfQ7M4E9Etjh7Iqg4b/EpO54Y8XLAJYZSkreOmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iNCveCeK; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672913427; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9GUJ/0ihFpj2roedif1DmfGOgBZkQ72X6uJoEOcw9hk=; b=qfvma7myHPGOWGMXOFgBUxTprUriOloN3kf7jekqfpTPs23hk23P1LOQB3ui0CmqUPuRyL ljenL6XExTtP3QoFlZ6Osv/4FMQfLAyguqepGdGXURGE6IeK1/A5GtzD4wDMb2U/98ZWPu y1yd44mWVDjkvg/FrQAf5PCRY8IJAitI/DbZ7zrvIoYLpAaQmfXdMuKUZ8cKeC+FsRN64G 3bpwm0fSkJCpD1MPwWOvNlXXmlD/MNFObsOyd5NDlAO2Q8amnVaBD2yr5QUe4tPMGw+1HO ZJv7PdhxS+5bPsyNsQg8hBfIiXDf08ancZrD0D2/9kYnWGLtiiQQUOyJ1mAnnw== X-Spam-Score: -1.06 X-Migadu-Queue-Id: A4ACBD258 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iNCveCeK; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -1.06 X-TUID: pBGwpV6oraqd Hi, On Thu, 08 Dec 2022 at 11:20, Christopher Baines wrote: > Add more examples of when it can be appropriate to push changes without > review, as I think this can be appropriate in the case of trivial changes= (as > mentioned before), but also non-trivial fixes. This would be part of the commit message, right? I would avoid the personal =E2=80=9CI think=E2=80=9D since it is a collecti= ve thought with some consensus (I guess). For instance, --8<---------------cut here---------------start------------->8--- Add more examples of when it can be appropriate to push changes without review, as in the case of trivial changes (as mentioned before), but also non-trivial fixes. --8<---------------cut here---------------end--------------->8--- > No longer suggest pushing simple new packages or package upgrades (that d= on't > cause lots of rebuilds) without sending to guix-patches. Now there's some > automation for testing changes sent to guix-patches, sending changes there > before pushing can mean that more rigerious testing takes place and help = speed --^ typo s/rigerious/rigorous =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 > +Changes should be posted to @email{guix-patches@@gnu.org}. This mailing > +list fills the patch-tracking database (@pxref{Tracking Bugs and > +Patches}). It also allows patches to be picked up and tested by the > +quality assurance tooling; the result of that testing eventually shows > +up on the dashboard at > +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where > +@var{number} is the number assigned by the issue tracker. Leave time To be consistent with (guix) Sending a Patch Series [1], I suggest to use @var{ISSUE_NUMBER} instead of simply @var{number}. 1: Aside the minor comments, all LGTM! This change appears to me a great improvement, hoping it will reduce the number of red bullets in dashboard [2]. 2: Cheers, simon