From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Hilton Chain <hako@ultrarare.space>
Cc: 65478@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>
Subject: [bug#65478] [PATCH emacs-team] gnu: emacs-flim-lb: Explicitly compile files to bytecode.
Date: Mon, 28 Aug 2023 20:28:00 +0200 [thread overview]
Message-ID: <7c8bcdbcb731ffc12b1769bb3fb2eca0900af32e.camel@gmail.com> (raw)
In-Reply-To: <87y1hv6blh.wl-hako@ultrarare.space>
Am Montag, dem 28.08.2023 um 12:21 +0800 schrieb Hilton Chain:
> And the following patch should work for Emacs 29, but not 28:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/guix/build/emacs-utils.scm b/guix/build/emacs-utils.scm
> index 850b1f5f2a..6c27b186e3 100644
> --- a/guix/build/emacs-utils.scm
> +++ b/guix/build/emacs-utils.scm
> @@ -138,7 +138,7 @@ (define* (emacs-compile-directory dir)
> (files (directory-files-recursively ,dir "\\.el$")))
> (mapc
> (lambda (file)
> - (let (byte-to-native-output-file
> + (let (byte-to-native-output-buffer-file
> ;; First entry is the eln-cache of the homeless
> shelter,
> ;; second entry is the install directory.
> (eln-dir (and (native-comp-available-p)
> @@ -148,12 +148,12 @@ (define* (emacs-compile-directory dir)
> (comp-el-to-eln-filename file eln-
> dir))
> (byte-compile-file file))
> ;; Sadly, we can't use pcase because quasiquote works
> different in
> - ;; Emacs. See `batch-byte+native-compile' in comp.el
> for the
> - ;; actual shape of byte-to-native-output-file.
> - (unless (null byte-to-native-output-file)
> - (rename-file (car byte-to-native-output-file)
> - (cdr byte-to-native-output-file)
> - t))))
> + ;; Emacs. See `comp-write-bytecode-file' in comp.el for
> the actual
> + ;; shape of byte-to-native-output-buffer-file.
We should probably mention that we don't have to hack the timestamp.
Or maybe we can use comp-write-bytecode-file directly?
> + (unless (null byte-to-native-output-buffer-file)
> + (byte-write-target-file
> + (car byte-to-native-output-buffer-file)
> + (cdr byte-to-native-output-buffer-file)))))
> files))
> #:dynamic? #t))
> --8<---------------cut here---------------end--------------->8---
Could you submit a properly cleaned version of this as v2 so that we
can get CI to build it along with proper attribution?
Cheers
next prev parent reply other threads:[~2023-08-28 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 18:00 [bug#65478] [PATCH emacs-team] gnu: emacs-flim-lb: Explicitly compile files to bytecode Hilton Chain via Guix-patches via
2023-08-27 6:24 ` Liliana Marie Prikler
2023-08-27 12:52 ` Hilton Chain via Guix-patches via
2023-08-27 15:13 ` Liliana Marie Prikler
2023-08-27 15:39 ` Hilton Chain via Guix-patches via
2023-08-27 15:49 ` Liliana Marie Prikler
2023-08-28 4:21 ` Hilton Chain via Guix-patches via
2023-08-28 18:28 ` Liliana Marie Prikler [this message]
2023-08-29 1:33 ` [bug#65478] [PATCH emacs-team v2] build: emacs-utils: Adjust `emacs-compile-directory' for Emacs 29 Hilton Chain via Guix-patches via
2023-08-30 19:40 ` Liliana Marie Prikler
2023-09-01 16:14 ` Hilton Chain via Guix-patches via
2023-09-01 16:15 ` [bug#65478] [PATCH emacs-team v3] " Hilton Chain via Guix-patches via
2023-09-01 19:37 ` Liliana Marie Prikler
2023-09-09 8:23 ` bug#65478: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c8bcdbcb731ffc12b1769bb3fb2eca0900af32e.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=65478@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=hako@ultrarare.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.