From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Hilton Chain <hako@ultrarare.space>, 65478@debbugs.gnu.org
Cc: Andrew Tropin <andrew@trop.in>
Subject: [bug#65478] [PATCH emacs-team v3] build: emacs-utils: Adjust `emacs-compile-directory' for Emacs 29.
Date: Fri, 01 Sep 2023 21:37:58 +0200 [thread overview]
Message-ID: <19403aa2ad67bd0cd4d35cf0b3332d1c18b1a197.camel@gmail.com> (raw)
In-Reply-To: <40fb61f0682e94c0fe402efad0193463e1f8b6bf.1693583097.git.hako@ultrarare.space>
Am Samstag, dem 02.09.2023 um 00:15 +0800 schrieb Hilton Chain:
> * guix/build/emacs-utils.scm (emacs-compile-directory): After native
> compilation, write the bytecode file with `comp-write-bytecode-file'.
> ---
> guix/build/emacs-utils.scm | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/guix/build/emacs-utils.scm b/guix/build/emacs-utils.scm
> index ac3dac57d1..8e12b5b6d4 100644
> --- a/guix/build/emacs-utils.scm
> +++ b/guix/build/emacs-utils.scm
> @@ -139,7 +139,7 @@ (define* (emacs-compile-directory dir)
> (files (directory-files-recursively ,dir "\\.el$")))
> (mapc
> (lambda (file)
> - (let (byte-to-native-output-file
> + (let (byte-to-native-output-buffer-file
> ;; First entry is the eln-cache of the homeless
> shelter,
> ;; second entry is the install directory.
> (eln-dir (and (native-comp-available-p)
> @@ -148,13 +148,9 @@ (define* (emacs-compile-directory dir)
> (native-compile file
> (comp-el-to-eln-filename file eln-
> dir))
> (byte-compile-file file))
> - ;; Sadly, we can't use pcase because quasiquote works
> different in
> - ;; Emacs. See `batch-byte+native-compile' in comp.el
> for the
> - ;; actual shape of byte-to-native-output-file.
> - (unless (null byte-to-native-output-file)
> - (rename-file (car byte-to-native-output-file)
> - (cdr byte-to-native-output-file)
> - t))))
> + ;; After native compilation, write the bytecode file.
> + (unless (null byte-to-native-output-buffer-file)
> + (comp-write-bytecode-file nil))))
> files))
> #:dynamic? #t))
LGTM, at least regarding emacs-flim-lb. I have it applied locally with
the fancy quotes made extra fancy; will wait for CI before pushing,
however.
Cheers
next prev parent reply other threads:[~2023-09-01 19:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 18:00 [bug#65478] [PATCH emacs-team] gnu: emacs-flim-lb: Explicitly compile files to bytecode Hilton Chain via Guix-patches via
2023-08-27 6:24 ` Liliana Marie Prikler
2023-08-27 12:52 ` Hilton Chain via Guix-patches via
2023-08-27 15:13 ` Liliana Marie Prikler
2023-08-27 15:39 ` Hilton Chain via Guix-patches via
2023-08-27 15:49 ` Liliana Marie Prikler
2023-08-28 4:21 ` Hilton Chain via Guix-patches via
2023-08-28 18:28 ` Liliana Marie Prikler
2023-08-29 1:33 ` [bug#65478] [PATCH emacs-team v2] build: emacs-utils: Adjust `emacs-compile-directory' for Emacs 29 Hilton Chain via Guix-patches via
2023-08-30 19:40 ` Liliana Marie Prikler
2023-09-01 16:14 ` Hilton Chain via Guix-patches via
2023-09-01 16:15 ` [bug#65478] [PATCH emacs-team v3] " Hilton Chain via Guix-patches via
2023-09-01 19:37 ` Liliana Marie Prikler [this message]
2023-09-09 8:23 ` bug#65478: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19403aa2ad67bd0cd4d35cf0b3332d1c18b1a197.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=65478@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=hako@ultrarare.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.