From: julien lepiller <julien@lepiller.eu>
To: guix-devel@gnu.org
Subject: Re: [PATCH 0/6] Error reporting and hints for missing modules
Date: Wed, 08 Nov 2017 16:33:16 +0100 [thread overview]
Message-ID: <72bfb7a9ff14c437a704381f807ce2f7@lepiller.eu> (raw)
In-Reply-To: <20171108130921.25202-1-ludo@gnu.org>
Le 2017-11-08 14:09, Ludovic Courtès a écrit :
> Hi!
>
> Here’s an improved version that supports hints (with Texinfo markup and
> i18n) and error reporting with source location info.
>
> Hints try to make suggestions. If you write:
>
> (use-package-modules qemu)
>
> You’ll get:
>
> configuration.scm:7:0: error: module (gnu packages qemu) not found
> hint: Did you mean `(use-package-modules virtualization)'?
>
> If you write:
>
> (use-service-modules openssh)
>
> You get:
>
> configuration.scm:9:0: error: module (gnu services openssh) not found
> hint: Did you mean `(use-service-modules ssh)'?
>
> The “did you mean” hints are based on exact matches on the package or
> service names. We could go as far as doing inexact searches akin to
> what “guix package -s” and “guix system search” do, but maybe that’s
> overkill given that the suggestions could be wrong.
>
> Anyway, I think that’s already an improvement and we can always refine
> it later.
>
> Thoughts?
This is great! I don't understand it all, but it seems like when there
is
no exact match for a package or service, we get the more generic hint
I wrote.
I'm happy with this version, so LGTM (though untested). Let's see what
George thinks about it.
>
> Ludo’.
>
> Ludovic Courtès (6):
> ui: Introduce (guix i18n).
> ui: Define and honor '&error-location' and '&fix-hint' conditions.
> services: 'fold-service-types' honors its seed.
> services: 'fold-service-types' includes (gnu services).
> services: Add 'lookup-service-types'.
> gnu: Improve error reporting of the use-.*modules macros.
>
> Makefile.am | 1 +
> gnu.scm | 100
> ++++++++++++++++++++++++++++++++++++++++++++++++---
> gnu/services.scm | 20 +++++++++--
> guix/i18n.scm | 51 ++++++++++++++++++++++++++
> guix/ui.scm | 50 ++++++++++++--------------
> guix/utils.scm | 17 +++++++++
> po/guix/POTFILES.in | 1 +
> tests/guix-system.sh | 28 +++++++++++++++
> tests/services.scm | 10 +++++-
> 9 files changed, 243 insertions(+), 35 deletions(-)
> create mode 100644 guix/i18n.scm
next prev parent reply other threads:[~2017-11-08 15:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 20:12 The usability of Guix configurations myglc2
2017-11-06 22:16 ` Leo Famulari
2017-11-06 23:26 ` myglc2
2017-11-06 23:26 ` bug#29072: " myglc2
2017-11-07 1:56 ` myglc2
2017-11-07 1:56 ` myglc2
2017-11-07 11:05 ` julien lepiller
2017-11-07 12:52 ` Hartmut Goebel
2017-11-07 13:13 ` julien lepiller
2017-11-07 14:11 ` myglc2
2017-11-07 14:52 ` julien lepiller
2017-11-07 15:59 ` myglc2
2017-11-07 16:25 ` [PATCH] " julien lepiller
[not found] ` <867ev2t13i.fsf@gmail.com>
2017-11-07 21:27 ` Julien Lepiller
2017-11-07 22:56 ` myglc2
2017-11-07 22:47 ` Reporting module errors Ludovic Courtès
2017-11-08 1:26 ` myglc2
2017-11-08 10:52 ` Hartmut Goebel
2017-11-08 14:02 ` Ludovic Courtès
2017-11-08 13:09 ` [PATCH 0/6] Error reporting and hints for missing modules Ludovic Courtès
2017-11-08 13:09 ` [PATCH 1/6] ui: Introduce (guix i18n) Ludovic Courtès
2017-11-08 13:09 ` [PATCH 2/6] ui: Define and honor '&error-location' and '&fix-hint' conditions Ludovic Courtès
2017-11-08 13:09 ` [PATCH 3/6] services: 'fold-service-types' honors its seed Ludovic Courtès
2017-11-08 13:09 ` [PATCH 4/6] services: 'fold-service-types' includes (gnu services) Ludovic Courtès
2017-11-08 13:09 ` [PATCH 5/6] services: Add 'lookup-service-types' Ludovic Courtès
2017-11-08 13:09 ` [PATCH 6/6] gnu: Improve error reporting of the use-.*modules macros Ludovic Courtès
2017-11-11 2:02 ` Chris Marusich
2017-11-11 13:56 ` Ludovic Courtès
2017-11-11 17:00 ` Chris Marusich
2017-11-08 15:33 ` julien lepiller [this message]
2017-11-08 17:42 ` [PATCH 0/6] Error reporting and hints for missing modules myglc2
2017-11-08 19:07 ` myglc2
2017-11-08 21:42 ` Ludovic Courtès
2017-11-09 23:04 ` Ludovic Courtès
2017-11-10 14:47 ` myglc2
2017-11-10 23:01 ` Julien Lepiller
2017-11-11 22:00 ` Ludovic Courtès
2017-11-11 22:02 ` Ludovic Courtès
2017-11-14 1:12 ` myglc2
2017-11-30 10:44 ` Ludovic Courtès
2017-11-07 14:45 ` The usability of Guix configurations Hartmut Goebel
2017-11-07 2:30 ` myglc2
2017-11-07 3:03 ` myglc2
2017-11-07 2:30 ` bug#29072: " myglc2
2017-11-07 2:59 ` myglc2
2017-11-07 20:54 ` myglc2
2017-11-06 22:16 ` bug#29072: " Leo Famulari
2017-11-07 10:23 ` Ludovic Courtès
2017-11-08 19:40 ` myglc2
2017-11-07 10:23 ` bug#29072: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72bfb7a9ff14c437a704381f807ce2f7@lepiller.eu \
--to=julien@lepiller.eu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.