From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Andrew Tropin <andrew@trop.in>, 52388@debbugs.gnu.org
Cc: Ivan Sokolov <ivan-p-sokolov@ya.ru>
Subject: [bug#52388] [PATCH] build-system: emacs: Add generation of -pkg.el files.
Date: Fri, 21 Jan 2022 17:57:35 +0100 [thread overview]
Message-ID: <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> (raw)
In-Reply-To: <87zgnp8f0n.fsf@trop.in>
Hi Andrew,
Am Freitag, dem 21.01.2022 um 15:11 +0300 schrieb Andrew Tropin:
> > As promised, I took a deeper look at your patch. As already noted,
> > there were some clean-up actions I had to perform, such as keeping
> > to our line limit (it was not easy, I tell you) among other
> > things. Also, confusingly, your condition-case code did not handle
> > errors and wrong handling of the version field blew up everything
> > for me. Did you test this code?
>
> I thought it was the version I used for past a few weeks, however I
> could send a little outdated version, not the latest one by accident.
> Tested it with guix build emacs-paredit.
>
> See your fix which wraps both forms in one let, thank you, yep, it's
> very likely I sent an intermediate version of the patch
> accidentially.
Git index not up to date, truly a classic :)
> > + ;; before trying to create package-desc. Otherwis the
> > whole process
>
> s/Otherwis/Otherwise,
Thanks.
>
> Applied on my local checkout of guix channel, list-packages now shows
> 117 external packages =) Will keep it for a while and let you know
> if any problems will reveal themselves.
Fair enough, I'll reset my "14 days without review" clock then :)
next prev parent reply other threads:[~2022-01-21 16:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 9:01 [bug#52388] [PATCH] build-system: emacs: Add generation of -pkg.el files Andrew Tropin
2022-01-14 20:56 ` Liliana Marie Prikler
2022-01-21 12:11 ` Andrew Tropin
2022-01-21 16:57 ` Liliana Marie Prikler [this message]
2022-01-28 15:29 ` Andrew Tropin
2022-01-29 7:53 ` bug#52388: " Liliana Marie Prikler
2022-01-31 17:18 ` [bug#52388] " Andrew Tropin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=52388@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=ivan-p-sokolov@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.