From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iJJjJyHm6mFVfwAAgWs5BA (envelope-from ) for ; Fri, 21 Jan 2022 17:58:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GHoNJCHm6mHyowAAauVa8A (envelope-from ) for ; Fri, 21 Jan 2022 17:58:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 490983A845 for ; Fri, 21 Jan 2022 17:58:09 +0100 (CET) Received: from localhost ([::1]:48494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAxEm-0001zF-BV for larch@yhetil.org; Fri, 21 Jan 2022 11:58:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAxEg-0001uQ-3U for guix-patches@gnu.org; Fri, 21 Jan 2022 11:58:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAxEf-0003z5-PZ for guix-patches@gnu.org; Fri, 21 Jan 2022 11:58:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAxEf-0003ed-LB for guix-patches@gnu.org; Fri, 21 Jan 2022 11:58:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52388] [PATCH] build-system: emacs: Add generation of -pkg.el files. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 Jan 2022 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52388 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin , 52388@debbugs.gnu.org Cc: Ivan Sokolov Received: via spool by 52388-submit@debbugs.gnu.org id=B52388.164278426514020 (code B ref 52388); Fri, 21 Jan 2022 16:58:01 +0000 Received: (at 52388) by debbugs.gnu.org; 21 Jan 2022 16:57:45 +0000 Received: from localhost ([127.0.0.1]:34968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAxEO-0003e4-TW for submit@debbugs.gnu.org; Fri, 21 Jan 2022 11:57:45 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:43532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAxEO-0003dn-7V for 52388@debbugs.gnu.org; Fri, 21 Jan 2022 11:57:44 -0500 Received: by mail-wm1-f65.google.com with SMTP id e9-20020a05600c4e4900b0034d23cae3f0so23146641wmq.2 for <52388@debbugs.gnu.org>; Fri, 21 Jan 2022 08:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=I3GUtbHiQba9dCZ/Hv+KJ1nozfbWK95oECQkDwdUwJc=; b=M3TvR39da/eJjDbEZURAoTPyoLHrUhP/bRHu2YVO30BjG6oww56h5MIRXwK93263xE +4XSEgVH30NOYWKYbV+CDzUvjbgjBuaLM3fGctN/tkrhe7C11DCeIEdf4Nyl7R0JtCHm /BVYDVH776pXoUHlB4pYgJjFVX5NzkSOVS6yV5dKeyJ88/8sY4ovRm+TGCuwlLg5Sr13 FQJA0Q2n0mTIqTLJTvTZYRLxzaP7DeQ70nQgZFSEsfBIm53TiUq9YznqX1WzK8tvcQmA JSt6ES+OXC0Q1k8Wj8soVNjUB+6AY2JQIG4ygLvuVvE/Rb28Zuwn5CA3CDGsCyXJWKN+ 7Ncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=I3GUtbHiQba9dCZ/Hv+KJ1nozfbWK95oECQkDwdUwJc=; b=gtvEkyVnqUMtAS4iNW/jnErk4Sf3J2cThPEPUYODbEFjqcL7e+FWUiv5jZ458uGRQJ 7i9rHLVYYWS51RC11/8CJyRoAYhEw+ajoDzdKFQK+iuUyRiGtcj0MtAE79/fmgDXpyPE kS0EF70RpsRNiPEUnUNaomLRQJigHz7KI0ITQ+B2HJBzBUdkViOuNZxIs+2GVFNNCZNW zXDZrQkugJHs1tJKUucIdyO9Bc09YHcOgZq/GMomiP53pbRithI81CR2GfOuA/Ad2nld aWAdhO4yPixbG/qT4/mrbWIAFoV318k7CZVdUHK7xxnGDy4VFMw729V8I2DZ8D+OpJno ifgA== X-Gm-Message-State: AOAM532o5iKMcWcSgnmS6TlYxjckjBE+Rfl7RacWbVcZJrdbaDDuGdAK 8YUANjTaI+ArZFojMR3Llg0= X-Google-Smtp-Source: ABdhPJxiveloZuXk1qohEfW3J3ppqeiRlU36toY43ZTDEcj/plXMDPF5/yKgQS4CTNbzolVvjinN8w== X-Received: by 2002:a7b:c0d4:: with SMTP id s20mr1501455wmh.113.1642784258121; Fri, 21 Jan 2022 08:57:38 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id z1sm10203388wma.20.2022.01.21.08.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:57:37 -0800 (PST) Message-ID: <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 21 Jan 2022 17:57:35 +0100 In-Reply-To: <87zgnp8f0n.fsf@trop.in> References: <871r2mrleb.fsf@trop.in> <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> <87zgnp8f0n.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642784289; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=I3GUtbHiQba9dCZ/Hv+KJ1nozfbWK95oECQkDwdUwJc=; b=r+RnsjVsqc53KLpPHs9a2xJFRZ1DnCVfxWXvgf8d8RnduVc3P8Kg/J5GegEL7dw36kkyNg Pd5iFsL483KuJVgs7088GDu4McXThA36v0E5Kurv3jPW/acPGXCE+Fid/Apr9zDUdHJgPW u0PII3xLnyOJwcnwDtnYDkOaRZSbylpfVFRCH4ZTnAwaiF+bu6WoxAfDMOq1XMAm2Dh2+q M6FitFldd2wWcLFu/suQ8+9RUNKYBYkJ5PMV8h5cgj3dlBzWM4W6NyxWMcG2zNRHFm0J14 UisXBZwsTMClsN/zmlR+0HrUrR7KQdh7x25z3LMulLJTpbKrEvkOztk20E5bJw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642784289; a=rsa-sha256; cv=none; b=MVnwA0Snvipot9b7xJqNpGq+m0nfDeId2zTZ8aGtjTr9dD6t0mkT6kr4uhdE9fXwB+tqVA OIQfbtvE2EvWipdsYsn2Iojpea3GeM0lsYY8lH3s/MzR3+YIUft4k4Th8FxkLsyVpQrgTs b7s+aFQuMudFK7u1+qJzGP6QGwBdLVXHbHO6i/323/SMLy5h7TCtS/5R1NeIoIbLJySkij ih33Pp8gMTCoWac63RNkAuVP1MkB/58jjL508847aiDhyAMNee7OZ8eW9YVVheY3QT+tcG H5ublzVdebLULGj2FACHXbGIbhA8GZYk1ooq498fSqPCYCG14jY8B5/ETeKfrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=M3TvR39d; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=M3TvR39d; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 490983A845 X-Spam-Score: -3.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7SB9pGVlgeVm Hi Andrew, Am Freitag, dem 21.01.2022 um 15:11 +0300 schrieb Andrew Tropin: > > As promised, I took a deeper look at your patch.  As already noted, > > there were some clean-up actions I had to perform, such as keeping > > to our line limit (it was not easy, I tell you) among other > > things.  Also, confusingly, your condition-case code did not handle > > errors and wrong handling of the version field blew up everything > > for me.  Did you test this code? > > I thought it was the version I used for past a few weeks, however I > could send a little outdated version, not the latest one by accident. > Tested it with guix build emacs-paredit. > > See your fix which wraps both forms in one let, thank you, yep, it's > very likely I sent an intermediate version of the patch > accidentially. Git index not up to date, truly a classic :) > > +           ;; before trying to create package-desc.  Otherwis the > > whole process > > s/Otherwis/Otherwise, Thanks. > > Applied on my local checkout of guix channel, list-packages now shows > 117 external packages =)  Will keep it for a while and let you know > if any problems will reveal themselves. Fair enough, I'll reset my "14 days without review" clock then :)