From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Christopher Baines <mail@cbaines.net>, 55591@debbugs.gnu.org
Subject: [bug#55591] [PATCH] WIP: fix the linux build system
Date: Tue, 24 May 2022 09:09:42 +0200 [thread overview]
Message-ID: <6bcd4de97c04b3ced47a573eaeade3f9e0284d3b.camel@ist.tugraz.at> (raw)
In-Reply-To: <20220523083332.21626-1-mail@cbaines.net>
Am Montag, dem 23.05.2022 um 09:33 +0100 schrieb Christopher Baines:
> ---
> gnu/platform.scm | 6 +++++-
> guix/build-system/linux-module.scm | 3 ++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/platform.scm b/gnu/platform.scm
> index fdc3685e7c..91a1854e68 100644
> --- a/gnu/platform.scm
> +++ b/gnu/platform.scm
> @@ -66,10 +66,14 @@ (define-record-type* <platform> platform make-
> platform
> platform?
> (target platform-target)
> (system platform-system)
> - (linux-architecture platform-linux-architecture
> + (linux-architecture platform-linux-architecture*
> (default #f))
> (glibc-dynamic-linker platform-glibc-dynamic-linker))
>
> +;; Provide a procedure so this can be used via module-ref
> +(define (platform-linux-architecture platform)
> + (platform-linux-architecture* platform))
> +
I'd use a percent prefix if the problem is that platform-linux-
architecture can not be called.
> ;;;
> ;;; Platforms.
> diff --git a/guix/build-system/linux-module.scm b/guix/build-
> system/linux-module.scm
> index 761ebe25b1..78a3ba95b2 100644
> --- a/guix/build-system/linux-module.scm
> +++ b/guix/build-system/linux-module.scm
> @@ -51,7 +51,8 @@ (define (default-linux)
>
> (define (system->arch system)
> (let ((module (resolve-interface '(gnu platform))))
> - ((module-ref module 'lookup-platform-by-target-or-system)
> system)))
> + ((module-ref module 'platform-linux-architecture)
> + ((module-ref module 'lookup-platform-by-target-or-system)
> system))))
Why not add a helper function named lookup-platform-architecture-by-
target-or-system to (gnu platform), which performs the lookup followed
by the platform-linux-architecture accessor?
Cheers
next prev parent reply other threads:[~2022-05-24 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 8:33 [bug#55591] [PATCH] WIP: fix the linux build system Christopher Baines
2022-05-24 7:09 ` Liliana Marie Prikler [this message]
2022-05-25 7:37 ` bug#55591: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bcd4de97c04b3ced47a573eaeade3f9e0284d3b.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=55591@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.