From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8NWKHS6FjGLSPQEAbAwnHQ (envelope-from ) for ; Tue, 24 May 2022 09:11:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YMBTHS6FjGKXFAAAauVa8A (envelope-from ) for ; Tue, 24 May 2022 09:11:42 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12324AFF4 for ; Tue, 24 May 2022 09:11:42 +0200 (CEST) Received: from localhost ([::1]:54972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntOhd-0000e8-Bm for larch@yhetil.org; Tue, 24 May 2022 03:11:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntOg8-0000c5-8N for guix-patches@gnu.org; Tue, 24 May 2022 03:10:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ntOg6-0007nD-Dh for guix-patches@gnu.org; Tue, 24 May 2022 03:10:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ntOg6-0004Qy-7G for guix-patches@gnu.org; Tue, 24 May 2022 03:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55591] [PATCH] WIP: fix the linux build system Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 May 2022 07:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55591 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , 55591@debbugs.gnu.org Received: via spool by 55591-submit@debbugs.gnu.org id=B55591.165337619117022 (code B ref 55591); Tue, 24 May 2022 07:10:02 +0000 Received: (at 55591) by debbugs.gnu.org; 24 May 2022 07:09:51 +0000 Received: from localhost ([127.0.0.1]:50841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntOfv-0004QU-JH for submit@debbugs.gnu.org; Tue, 24 May 2022 03:09:51 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:52781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntOfq-0004QH-6v for 55591@debbugs.gnu.org; Tue, 24 May 2022 03:09:50 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4L6lgq578jz1DPhf; Tue, 24 May 2022 09:09:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4L6lgq578jz1DPhf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1653376183; bh=PYg+Ufu9rJS78tUlHZ5Zz/A7ihl7j6bWSXxCWBoAaTE=; h=Subject:From:To:Date:In-Reply-To:References:From; b=KidhNsaS3U+2UUHtrnD4aRJ6xvHccEdqbVO+OgSgc3OhCWaQT+1GTtiSdMwmoACSu 60Uy7dF9xMnHFVFI8Z14loMLgEeJ9+dCxV7Tl08SbWqvFLcZ+lOtEzQiXYKemO8ePX sYdAwh0hv2RmORC2ft+5EzrAppmPv39hOjGpYgzs= Message-ID: <6bcd4de97c04b3ced47a573eaeade3f9e0284d3b.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Tue, 24 May 2022 09:09:42 +0200 In-Reply-To: <20220523083332.21626-1-mail@cbaines.net> References: <20220523083332.21626-1-mail@cbaines.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653376302; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PYg+Ufu9rJS78tUlHZ5Zz/A7ihl7j6bWSXxCWBoAaTE=; b=N16jh9byzJAIEKN7aNrQpz9aaepcZuLW0Ue6GILBdVdp//z2v/NseDrDM0rdBYKbYPTMPs m1f24aAq4Vg43GMg/R7ihPpDdRSQz4oNUJjLYEHboP9o9LxNhv2/ULotJ2HBn/0oPIk7TG JvF0W8y4S6mswHTtW0MHKY11AhSig9GcdzbGmBjZuDguWslyowzmMQK0J5fLEQgd8N9D70 Y1VqxlBEtUJNifTJdP7Ab3ISUJ6qIZMUQ7fRCtEP1M240rckLbbLcqQo+m3Cf7ut5BlgvL 8sP1hB2EJ1tDebHHUdq1XyIpTX1vSERfY4wajxm1pEI6kE1BQjJn1Xw0FSRnwg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653376302; a=rsa-sha256; cv=none; b=dYLeXsXVl38GOSZlVoseKS/QHHk8kIygLoiwOAeiRYs94DvgCzcwwo79m6FYM4n6jccXae afqW5NjdVD26Hsp2lv40Rc7ikR/gowGAOnxnbM4Z4oWH45CY3ha478zUnXT365fMaZ9YVF ZDrH0/6/mzU9zAhKm9Yjf/8aOOTVLPWdiybu/dHDsU313xfZZ/8PSMI+e7rpPQsMB02Xcs JxIaNIQDVRxzjSdDDT3v9zhpGxHF2U0fKMJZPKECzMjupXS6zhzsgzmEfES6eyPEXCaY/5 FhxUFRe8Gq72Bax2pa9vlUae1oYPGiMFOYW49nI/VrB8FLWULSBF2aOKOFZ5fg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=KidhNsaS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=KidhNsaS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 12324AFF4 X-Spam-Score: 7.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: wJOlQ1KRW9zR Am Montag, dem 23.05.2022 um 09:33 +0100 schrieb Christopher Baines: > --- >  gnu/platform.scm                   | 6 +++++- >  guix/build-system/linux-module.scm | 3 ++- >  2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/gnu/platform.scm b/gnu/platform.scm > index fdc3685e7c..91a1854e68 100644 > --- a/gnu/platform.scm > +++ b/gnu/platform.scm > @@ -66,10 +66,14 @@ (define-record-type* platform make- > platform >    platform? >    (target               platform-target) >    (system               platform-system) > -  (linux-architecture   platform-linux-architecture > +  (linux-architecture   platform-linux-architecture* >                          (default #f)) >    (glibc-dynamic-linker platform-glibc-dynamic-linker)) >   > +;; Provide a procedure so this can be used via module-ref > +(define (platform-linux-architecture platform) > +  (platform-linux-architecture* platform)) > + I'd use a percent prefix if the problem is that platform-linux- architecture can not be called. >  ;;; >  ;;; Platforms. > diff --git a/guix/build-system/linux-module.scm b/guix/build- > system/linux-module.scm > index 761ebe25b1..78a3ba95b2 100644 > --- a/guix/build-system/linux-module.scm > +++ b/guix/build-system/linux-module.scm > @@ -51,7 +51,8 @@ (define (default-linux) >   >  (define (system->arch system) >    (let ((module (resolve-interface '(gnu platform)))) > -    ((module-ref module 'lookup-platform-by-target-or-system) > system))) > +    ((module-ref module 'platform-linux-architecture) > +     ((module-ref module 'lookup-platform-by-target-or-system) > system)))) Why not add a helper function named lookup-platform-architecture-by- target-or-system to (gnu platform), which performs the lookup followed by the platform-linux-architecture accessor? Cheers