all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#63798] [PATCH] Fix Erlang package substitutions
@ 2023-05-29 22:22 wrobell
  2023-06-20 10:48 ` wrobell
  2023-07-01 10:07 ` bug#63798: " Nicolas Goaziou
  0 siblings, 2 replies; 3+ messages in thread
From: wrobell @ 2023-05-29 22:22 UTC (permalink / raw)
  To: 63798; +Cc: wrobell

Both `dirname` and `basename` need to be substituted. There is no need
for `sed` substitution in Erlag 25.3.
---
 gnu/packages/erlang.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index 7564c2a560..b6e82e0109 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2021 Oskar Köök <oskar@maatriks.ee>
 ;;; Copyright © 2021 Cees de Groot <cg@evrl.com>
 ;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2023 wrobell <wrobell@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -168,7 +169,8 @@ (define-public erlang
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
                (substitute* (string-append out "/bin/erl")
-                 (("sed") (which "sed"))))))
+                 (("basename") (which "basename"))
+                 (("dirname") (which "dirname"))))))
          (add-after 'install 'install-doc
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))

base-commit: 7b400e7f8751e6b0cc6e66d3f7ecfb7f5bd51309
-- 
2.40.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#63798] [PATCH] Fix Erlang package substitutions
  2023-05-29 22:22 [bug#63798] [PATCH] Fix Erlang package substitutions wrobell
@ 2023-06-20 10:48 ` wrobell
  2023-07-01 10:07 ` bug#63798: " Nicolas Goaziou
  1 sibling, 0 replies; 3+ messages in thread
From: wrobell @ 2023-06-20 10:48 UTC (permalink / raw)
  To: 63798

I believe, the fix is required when I run my custom RabbitMQ package.

Also, some other user experiences the same issue

    https://lists.gnu.org/archive/html/guix-devel/2023-04/msg00003.html

Best regards,

w

--
https://mortgage.diy-labs.eu/




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#63798: [PATCH] Fix Erlang package substitutions
  2023-05-29 22:22 [bug#63798] [PATCH] Fix Erlang package substitutions wrobell
  2023-06-20 10:48 ` wrobell
@ 2023-07-01 10:07 ` Nicolas Goaziou
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Goaziou @ 2023-07-01 10:07 UTC (permalink / raw)
  To: wrobell; +Cc: 63798-done

Hello,

wrobell <wrobell@riseup.net> writes:

> Both `dirname` and `basename` need to be substituted. There is no need
> for `sed` substitution in Erlag 25.3.

Applied, with a proper commit message. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-01 10:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-29 22:22 [bug#63798] [PATCH] Fix Erlang package substitutions wrobell
2023-06-20 10:48 ` wrobell
2023-07-01 10:07 ` bug#63798: " Nicolas Goaziou

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.