[bug#53893] Fix non-sequencer from failing to build

[bug#53893] Fix non-sequencer from failing to build

[sughosha--- via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #1.2: Type: text/html, Size: 261 bytes --]

[-- Attachment #2: fix-non-sequencer.patch --]
[-- Type: application/octet-stream, Size: 485 bytes --]

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ddb1126a47..5a67a6e0d2 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1773,7 +1773,7 @@ (define-public non-sequencer
                      '()))
          #:python ,python-2))
       (inputs
-       (list jack-1 libsigc++ liblo ntk))
+       (list jack-1 libsigc++-2 liblo ntk))
       (native-inputs
        (list pkg-config))
       (home-page "https://non.tuxfamily.org/wiki/Non%20Sequencer")

[bug#53893] Fix non-sequencer from failing to build

[Leo Famulari]

On Wed, Feb 09, 2022 at 03:46:02AM +0000, sughosha--- via Guix-patches via wrote:
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index ddb1126a47..5a67a6e0d2 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -1773,7 +1773,7 @@ (define-public non-sequencer
>                       '()))
>           #:python ,python-2))
>        (inputs
> -       (list jack-1 libsigc++ liblo ntk))
> +       (list jack-1 libsigc++-2 liblo ntk))
>        (native-inputs
>         (list pkg-config))
>        (home-page "https://non.tuxfamily.org/wiki/Non%20Sequencer")

Thanks! I confirm it fixes the issue.

Normally I would push your change now. However, I'm not sure who to
credit for the fix.

You are free to use any name and email address that you prefer,
including pseudonyms.

Because this is your first patch (and would be your first commit in our
Git repo), I want to check with you what you want to appear in the Git
author field and the list of authors of 'gnu/packages/music.scm':

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/music.scm

As you continue to contribute, you can learn how to follow the steps
in the manual section Submitting Patches, and then your patches will
include this info when they are sent.

[bug#53893] Fix non-sequencer from failing to build

[sughosha--- via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

Hi,

Thanks for considoring this patch. Crediting me as `Sughosha <sughosha@disroot.org>` would be fine. I look forward to learn how to include this while sending the patch.

Regards,
Sughosha

[-- Attachment #2: Type: text/html, Size: 470 bytes --]

[bug#53893] Fix non-sequencer from failing to build

[Leo Famulari]

On Thu, Feb 10, 2022 at 11:18:17AM +0000, sughosha--- via Guix-patches via wrote:
> Hi,
> 
> Thanks for considoring this patch. Crediting me as `Sughosha <sughosha@disroot.org>` would be fine.

Okay, I pushed your fix as commit
6bfb3fc1f450c7d618041303d0ff35691b5991c0:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6bfb3fc1f450c7d618041303d0ff35691b5991c0

> I look forward to learn how to include this while sending the patch.

If you use Git to contribute to Guix, then your work will include
authorship information as part of the commits that you generate patches
from.