[bug#36060] [PATCH] services: cups: Create /var/cache on activation.

[bug#36060] [PATCH] services: cups: Create /var/cache on activation.

[Alex Griffin]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

I recently ran into the situation where CUPS wouldn't start because /var/cache didn't exist yet. This patch just creates /var/cache on CUPS activation.

-- 
Alex Griffin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-services-cups-Create-var-cache-on-activation.patch --]
[-- Type: text/x-patch; name="0001-services-cups-Create-var-cache-on-activation.patch", Size: 1202 bytes --]

From 4a2335d70088ad485ca2f91d5f21a4e7078fb927 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Sun, 2 Jun 2019 16:26:47 -0500
Subject: [PATCH] services: cups: Create /var/cache on activation.

* gnu/services/cups.scm (%cups-activation): Create /var/cache if it doesn't
exist yet.
---
 gnu/services/cups.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/services/cups.scm b/gnu/services/cups.scm
index 9125139ef3..4cdc83452f 100644
--- a/gnu/services/cups.scm
+++ b/gnu/services/cups.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016 Andy Wingo <wingo@pobox.com>
 ;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
 ;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2019 Alex Griffin <a@ajgrf.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -897,6 +898,7 @@ IPP specifications.")
           (mkdir-p/perms "/var/log/cups" user #o755)
           (mkdir-p/perms "/etc/cups" user #o755)
           (mkdir-p/perms "/etc/cups/ssl" user #o700)
+          (mkdir-p "/var/cache")
           ;; This certificate is used for HTTPS connections to the CUPS web
           ;; interface.
           (create-self-signed-certificate-if-absent
-- 
2.21.0

[bug#36060] [PATCH] services: cups: Create /var/cache on activation.

[Alex Griffin]

[-- Attachment #1: Type: text/plain, Size: 131 bytes --]

Maybe this patch fits in a little better. I used mkdir-p/perms like the surrounding code instead of just mkdir-p.

-- 
Alex Griffin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-services-cups-Create-var-cache-on-activation.patch --]
[-- Type: text/x-patch; name="0001-services-cups-Create-var-cache-on-activation.patch", Size: 1219 bytes --]

From b09759e4a2a348d6bdd1fef9593871e9e0a75a68 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Sun, 2 Jun 2019 16:26:47 -0500
Subject: [PATCH] services: cups: Create /var/cache on activation.

* gnu/services/cups.scm (%cups-activation): Create /var/cache if it doesn't
exist yet.
---
 gnu/services/cups.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/services/cups.scm b/gnu/services/cups.scm
index 9125139ef3..5d9e373117 100644
--- a/gnu/services/cups.scm
+++ b/gnu/services/cups.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016 Andy Wingo <wingo@pobox.com>
 ;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
 ;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2019 Alex Griffin <a@ajgrf.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -897,6 +898,7 @@ IPP specifications.")
           (mkdir-p/perms "/var/log/cups" user #o755)
           (mkdir-p/perms "/etc/cups" user #o755)
           (mkdir-p/perms "/etc/cups/ssl" user #o700)
+          (mkdir-p/perms "/var/cache" user #o770)
           ;; This certificate is used for HTTPS connections to the CUPS web
           ;; interface.
           (create-self-signed-certificate-if-absent
-- 
2.21.0

[bug#36060] [PATCH] services: cups: Create /var/cache on activation.

[Alex Griffin]

[-- Attachment #1: Type: text/plain, Size: 131 bytes --]

Maybe this patch fits in a little better. I used mkdir-p/perms like the surrounding code instead of just mkdir-p.

-- 
Alex Griffin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-services-cups-Create-var-cache-on-activation.patch --]
[-- Type: text/x-patch; name="0001-services-cups-Create-var-cache-on-activation.patch", Size: 1262 bytes --]

From 2ef61ab79cb387e00317cda54d893c061d9a1206 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Sun, 2 Jun 2019 16:26:47 -0500
Subject: [PATCH] services: cups: Create /var/cache on activation.

* gnu/services/cups.scm (%cups-activation): Create /var/cache if it doesn't
exist yet.
---
 gnu/services/cups.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/services/cups.scm b/gnu/services/cups.scm
index 9125139ef3..9d21b6e70c 100644
--- a/gnu/services/cups.scm
+++ b/gnu/services/cups.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016 Andy Wingo <wingo@pobox.com>
 ;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
 ;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2019 Alex Griffin <a@ajgrf.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -895,6 +896,7 @@ IPP specifications.")
           (mkdir-p/perms "/var/spool/cups" user #o755)
           (mkdir-p/perms "/var/spool/cups/tmp" user #o755)
           (mkdir-p/perms "/var/log/cups" user #o755)
+          (mkdir-p/perms "/var/cache/cups" user #o770)
           (mkdir-p/perms "/etc/cups" user #o755)
           (mkdir-p/perms "/etc/cups/ssl" user #o700)
           ;; This certificate is used for HTTPS connections to the CUPS web
-- 
2.21.0

bug#36060: [PATCH] services: cups: Create /var/cache on activation.

[Ludovic Courtès]

Hi Alex,

"Alex Griffin" <a@ajgrf.com> skribis:

> From 2ef61ab79cb387e00317cda54d893c061d9a1206 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a@ajgrf.com>
> Date: Sun, 2 Jun 2019 16:26:47 -0500
> Subject: [PATCH] services: cups: Create /var/cache on activation.
>
> * gnu/services/cups.scm (%cups-activation): Create /var/cache if it doesn't
> exist yet.

Applied, thanks!

Ludo'.