From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Anadon <joshua.r.marshall.1991@gmail.com>
Cc: 45604@debbugs.gnu.org
Subject: [bug#45604] [PATCH 1/1] Added a package definition for the C++17 header only library 'magic-enum'.
Date: Thu, 14 Jan 2021 12:59:49 +0100 [thread overview]
Message-ID: <6733a5f6ccb0bb3b189eaca8d61fd5bc58924d07.camel@student.tugraz.at> (raw)
In-Reply-To: <20210114023630.53568-2-joshua.r.marshall.1991@gmail.com>
Hello Anadon,
I was prepared to overlook some formal errors and push this with some
slight adjustment, but my package build failed, so I'll have to make
you adjust it once again.
Am Mittwoch, den 13.01.2021, 21:36 -0500 schrieb Anadon:
> gnu/packages/cpp.scm: Added the package definition.
The commit message for this package should be (minus indentation)
gnu: Add magic-enum.
* gnu/packages/cpp.scm (magic-enum): New variable.
to keep with the already established style.
You don't need to send a cover letter for a single patch. Also, don't
include guix-patches in your follow-up messages, but do CC me.
Additionally, it'd be nice if you used --reroll-count, but I'll sort
things out.
> ---
> gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 00e006928e..673867dbd2 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -807,3 +807,27 @@ code will be mixed in with the actual
> programming logic. This implementation
> provides a number of utilities to make coding with expected
> cleaner.")
> (home-page "https://tl.tartanllama.xyz/")
> (license license:cc0)))
> +
> +(define-public magic-enum
> + (package
> + (name "magic-enum")
> + (version "0.7.2")
> + (home-page "https://github.com/Neargye/magic_enum")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url home-page)
> + (commit (string-append "v" version))))
Missing (file-name (git-file-name name version)).
This is needed with git-references as otherwise it'll just be named
"git-checkout", which isn't very helpful.
> + (sha256
> + (base32
> + "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> sv2"))
After I recently cleaned my checkout completely (unrelated bytecode
troubles), this hash does not match up the one I get with `guix build'.
r:sha256 hash mismatch for /gnu/store/ajxz311mls8ybih8cify2lcwnwkqd1wy-
git-checkout:
expected hash: 0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2
actual hash: 07j5zdf3vkliwrcv6k663k35akn7qp23794sz2mnvkj9hbv9s8cx
Did something change upstream?
> + (modules '((guix build utils)))))
modules should only be needed if you have a snippet.
> + (build-system cmake-build-system)
> +
> + (inputs
> + `(("gcc" ,gcc-9)))
Should probably be native-inputs.
> + (synopsis "C++17 header only library for compile time
> reflection of enums")
> + (description "C++17 header only library which offers static
> reflection
> +of enums, with to string, from string, and iteration, and related
> +functionality.")
> + (license license:expat)))
Regards,
Leo
next prev parent reply other threads:[~2021-01-14 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 2:36 [bug#45852] [PATCH 0/1] New package 'magic-enum' Anadon
2021-01-14 2:36 ` [bug#45853] [PATCH 1/1] Added a package definition for the C++17 header only library 'magic-enum' Anadon
2021-01-14 11:59 ` Leo Prikler [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-14 2:17 [bug#45850] [PATCH 0/1] New package 'magic-enum' Anadon
2021-01-14 2:17 ` [bug#45604] [PATCH 1/1] Added a package definition for the C++17 header only library 'magic-enum' Anadon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6733a5f6ccb0bb3b189eaca8d61fd5bc58924d07.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=45604@debbugs.gnu.org \
--cc=joshua.r.marshall.1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.