From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aClrHE8yAGBCFAAA0tVLHw (envelope-from ) for ; Thu, 14 Jan 2021 12:00:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qEEcGE8yAGAHIwAAbx9fmQ (envelope-from ) for ; Thu, 14 Jan 2021 12:00:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3CF894042E for ; Thu, 14 Jan 2021 12:00:11 +0000 (UTC) Received: from localhost ([::1]:35600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l01IQ-0008Uv-G4 for larch@yhetil.org; Thu, 14 Jan 2021 07:00:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l01II-0008Up-Vz for guix-patches@gnu.org; Thu, 14 Jan 2021 07:00:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l01II-00046V-O0 for guix-patches@gnu.org; Thu, 14 Jan 2021 07:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l01II-0007UQ-LI for guix-patches@gnu.org; Thu, 14 Jan 2021 07:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45604] [PATCH 1/1] Added a package definition for the C++17 header only library 'magic-enum'. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 Jan 2021 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Anadon Received: via spool by 45604-submit@debbugs.gnu.org id=B45604.161062559828754 (code B ref 45604); Thu, 14 Jan 2021 12:00:02 +0000 Received: (at 45604) by debbugs.gnu.org; 14 Jan 2021 11:59:58 +0000 Received: from localhost ([127.0.0.1]:37383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l01ID-0007Ti-Th for submit@debbugs.gnu.org; Thu, 14 Jan 2021 06:59:58 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:64469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l01IA-0007TW-MD for 45604@debbugs.gnu.org; Thu, 14 Jan 2021 06:59:57 -0500 Received: from nijino.local (217-149-169-137.nat.highway.telekom.at [217.149.169.137]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DGjY21xnqz1LWp5; Thu, 14 Jan 2021 12:59:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DGjY21xnqz1LWp5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1610625590; bh=lzB/fSLKT09ubq8QtH1vQRTzE+fp06+ksNjfL/q0Khk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=prNRN610rzVKj5XhEvLTpEpx5/ObcQqoMxeiF0K9b0Bhyx3pBNFqcZpkF5bO3E4BY ee8GHNqcClLak4PNTqsrKWXirFFAE2BhOI6LkyHSDKFAUSda6wrskev/Y1ji5FtwqP OxJJ0yuRv3RTfsaHuvNqc57J5EBnr5LD3k7Xu4HA= Message-ID: <6733a5f6ccb0bb3b189eaca8d61fd5bc58924d07.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 14 Jan 2021 12:59:49 +0100 In-Reply-To: <20210114023630.53568-2-joshua.r.marshall.1991@gmail.com> References: <20210114023630.53568-1-joshua.r.marshall.1991@gmail.com> <20210114023630.53568-2-joshua.r.marshall.1991@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45604@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=prNRN610; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A3CF894042E X-Spam-Score: -1.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: ePoNAx5k5rEk Hello Anadon, I was prepared to overlook some formal errors and push this with some slight adjustment, but my package build failed, so I'll have to make you adjust it once again. Am Mittwoch, den 13.01.2021, 21:36 -0500 schrieb Anadon: > gnu/packages/cpp.scm: Added the package definition. The commit message for this package should be (minus indentation) gnu: Add magic-enum. * gnu/packages/cpp.scm (magic-enum): New variable. to keep with the already established style. You don't need to send a cover letter for a single patch. Also, don't include guix-patches in your follow-up messages, but do CC me. Additionally, it'd be nice if you used --reroll-count, but I'll sort things out. > --- > gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm > index 00e006928e..673867dbd2 100644 > --- a/gnu/packages/cpp.scm > +++ b/gnu/packages/cpp.scm > @@ -807,3 +807,27 @@ code will be mixed in with the actual > programming logic. This implementation > provides a number of utilities to make coding with expected > cleaner.") > (home-page "https://tl.tartanllama.xyz/") > (license license:cc0))) > + > +(define-public magic-enum > + (package > + (name "magic-enum") > + (version "0.7.2") > + (home-page "https://github.com/Neargye/magic_enum") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url home-page) > + (commit (string-append "v" version)))) Missing (file-name (git-file-name name version)). This is needed with git-references as otherwise it'll just be named "git-checkout", which isn't very helpful. > + (sha256 > + (base32 > + "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil > sv2")) After I recently cleaned my checkout completely (unrelated bytecode troubles), this hash does not match up the one I get with `guix build'. r:sha256 hash mismatch for /gnu/store/ajxz311mls8ybih8cify2lcwnwkqd1wy- git-checkout: expected hash: 0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2 actual hash: 07j5zdf3vkliwrcv6k663k35akn7qp23794sz2mnvkj9hbv9s8cx Did something change upstream? > + (modules '((guix build utils))))) modules should only be needed if you have a snippet. > + (build-system cmake-build-system) > + > + (inputs > + `(("gcc" ,gcc-9))) Should probably be native-inputs. > + (synopsis "C++17 header only library for compile time > reflection of enums") > + (description "C++17 header only library which offers static > reflection > +of enums, with to string, from string, and iteration, and related > +functionality.") > + (license license:expat))) Regards, Leo