[bug#70560] [PATCH] gnu: Resolve poweron script failure vmware-open-vm-tools

[bug#70560] [PATCH] gnu: Resolve poweron script failure vmware-open-vm-tools

[Deslauriers, Douglas via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

Hello Guix,

I have attached my first patch. This resolves a failing script in the
`vmware-open-vm-tools` package due to the package's daemon trying to
execute a script in the `/etc/` directory. A substitution has been
added so that the built binary will now execute that script from the
proper location in the store.

I ran `guix style` on this package and it seems that the entire package
definition isn't formatted, but I didn't add that to my patch since
that would beyond the scope of this change. Please let me know if there
is anything else I should update or change.

Regards,
Douglas Deslauriers

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Resolve-poweron-script-failure-open-vm-tools.patch --]
[-- Type: text/x-patch; name="0001-gnu-Resolve-poweron-script-failure-open-vm-tools.patch", Size: 1818 bytes --]

From 299233a887e97b6fcb1e40a2fd2eb0a1d1556d67 Mon Sep 17 00:00:00 2001
Message-ID: <299233a887e97b6fcb1e40a2fd2eb0a1d1556d67.1713980728.git.Douglas.Deslauriers@vector.com>
From: Douglas Deslauriers <Douglas.Deslauriers@vector.com>
Date: Wed, 24 Apr 2024 08:41:20 -0400
Subject: [PATCH] gnu: Resolve poweron script failure open-vm-tools.

    * gnu/packages/virtualization.scm (vmware-open-vm-tools,
    vmware-open-vm-tools-gtk)[arguments]: Added a substitution to
    provide a proper path to the store for running the power-on script.

Change-Id: I9671d3c134e3aafdc610d2c168be46dbc95bdea8
---
 gnu/packages/virtualization.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 34cccd6550..00cc50aa37 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2023 Ahmad Draidi <a.r.draidi@redscript.org>
 ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus@gmail.com>
 ;;; Copyright © 2023, 2024 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2024 Douglas Deslauriers <Douglas.Deslauriers@vector.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1787,6 +1788,9 @@ (define-public vmware-open-vm-tools
                 (("/bin/fusermount3")
                  (string-append
                   #$(this-package-input "fuse") "/bin/fusermount3")))
+              (substitute* "lib/guestApp/guestApp.c"
+                (("/etc/vmware-tools")
+                 (string-append #$output "/etc/vmware-tools")))
               ;; XXX: This part might need more testing with shutdown and halt
               ;; commands provided by Shepherd.
               (substitute* "lib/system/systemLinux.c"

base-commit: e2ba93373a29ddf5d5754368957e89f3b426bb0a
-- 
2.41.0