* [bug#52763] [PATCH] etc: Match define-public only at line start.
@ 2021-12-24 0:33 Liliana Marie Prikler
2022-01-05 22:25 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Liliana Marie Prikler @ 2021-12-24 0:33 UTC (permalink / raw)
To: 52763
The current regexp simply matches the first occurence, which more often than
not points to the *previous* variable.
* etc/snippets/text-mode/guix-commit-message-update-package ($1): Restrict
match to beginning of line with optional indentation.
---
etc/snippets/text-mode/guix-commit-message-update-package | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/etc/snippets/text-mode/guix-commit-message-update-package b/etc/snippets/text-mode/guix-commit-message-update-package
index f187419aa2..b08df74a0b 100644
--- a/etc/snippets/text-mode/guix-commit-message-update-package
+++ b/etc/snippets/text-mode/guix-commit-message-update-package
@@ -8,7 +8,7 @@ gnu: ${1:`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
(goto-char (point-min))
- (when (re-search-forward "(define-public \\(\\S-+\\)" nil 'noerror)
+ (when (re-search-forward "^[ ]*(define-public \\(\\S-+\\)" nil 'noerror)
(match-string-no-properties 1)))`}: Update to ${2:`(with-temp-buffer
(magit-git-wash #'magit-diff-wash-diffs
"diff" "--staged")
--
2.34.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#52763] [PATCH] etc: Match define-public only at line start.
2021-12-24 0:33 [bug#52763] [PATCH] etc: Match define-public only at line start Liliana Marie Prikler
@ 2022-01-05 22:25 ` Ludovic Courtès
2022-01-19 20:17 ` bug#52763: " Liliana Marie Prikler
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2022-01-05 22:25 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 52763
Hi,
Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> The current regexp simply matches the first occurence, which more often than
> not points to the *previous* variable.
>
> * etc/snippets/text-mode/guix-commit-message-update-package ($1): Restrict
> match to beginning of line with optional indentation.
LGTM, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#52763: [PATCH] etc: Match define-public only at line start.
2022-01-05 22:25 ` Ludovic Courtès
@ 2022-01-19 20:17 ` Liliana Marie Prikler
0 siblings, 0 replies; 3+ messages in thread
From: Liliana Marie Prikler @ 2022-01-19 20:17 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 52763-done
Am Mittwoch, dem 05.01.2022 um 23:25 +0100 schrieb Ludovic Courtès:
> Hi,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
>
> > The current regexp simply matches the first occurence, which more
> > often than not points to the *previous* variable.
> >
> > * etc/snippets/text-mode/guix-commit-message-update-package ($1):
> > Restrict match to beginning of line with optional indentation.
>
> LGTM, thanks!
The manual says 14 days after no review, not 14 days after review.
Pushed now :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-19 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-24 0:33 [bug#52763] [PATCH] etc: Match define-public only at line start Liliana Marie Prikler
2022-01-05 22:25 ` Ludovic Courtès
2022-01-19 20:17 ` bug#52763: " Liliana Marie Prikler
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.