From: Martin Becze <mjbecze@riseup.net>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 44470@debbugs.gnu.org
Subject: [bug#44470] [PATCH] gnu: Added emacs-solidity.
Date: Thu, 5 Nov 2020 13:52:46 -0600 [thread overview]
Message-ID: <5805b82e-8aa5-d7ef-5fae-69a7d86ffe59@riseup.net> (raw)
In-Reply-To: <87zh3vlokf.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]
> If we use the commit above, `version' can simply become "0.1.10".
Opps sorry missed this comment. Attached is a patch that fixes that too.
On 11/5/20 11:07 AM, Nicolas Goaziou wrote:
> Hello,
>
> Martin Becze <mjbecze@riseup.net> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
>
> Thank you.
>
>> + ;; No release.
>> + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
>
> Is there any reason to use this particular instead of
> e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10"
> release? If so, please mention it in the comment above.
>
>> + (package
>> + (name "emacs-solidity")
>> + (version (git-version "0.1.10" "1" commit))
>
> If we use the commit above, `version' can simply become "0.1.10".
>
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/ethereum/emacs-solidity")
>> + (commit commit)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
>> + (build-system emacs-build-system)
>> + (propagated-inputs
>> + `(("emacs-company" ,emacs-company)
>> + ("emacs-flycheck" ,emacs-flycheck)))
>> + (home-page "https://github.com/ethereum/emacs-solidity")
>> + (synopsis "Major mode for writing Solidity code")
>> + (description "A simple language mode for the Solidity language. It is a
>> +constant work in progress as the language itself also progresses.")
>
> The first sentence should be "complete", i.e., with a subject and
> a verb.
>
> Could you send an updated patch?
>
> Regards,
>
[-- Attachment #2: v3-0001-gnu-Added-emacs-solidity.patch --]
[-- Type: text/x-patch, Size: 1755 bytes --]
From c8f9487a07700f5ed17b2ddd726e30c4bf21acec Mon Sep 17 00:00:00 2001
From: Martin Becze <mjbecze@riseup.net>
Date: Thu, 5 Nov 2020 09:18:01 -0600
Subject: [PATCH v3] gnu: Added emacs-solidity.
* gnu/packages/emacs-xyz.scm (emacs-solidity): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2043ce19df..846429fbdf 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25281,3 +25281,28 @@ the TypeScript implementation.")
(description "This package provides an Emacs client for the Rocket.chat
service.")
(license license:expat))))
+
+(define-public emacs-solidity
+ ;; This commit fixes a spacing issue and adds new keywords
+ (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e"))
+ (package
+ (name "emacs-solidity")
+ (version "0.1.10")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ethereum/emacs-solidity")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-company" ,emacs-company)
+ ("emacs-flycheck" ,emacs-flycheck)))
+ (home-page "https://github.com/ethereum/emacs-solidity")
+ (synopsis "Major mode for writing Solidity code")
+ (description "This is a simple language mode for the Solidity language.
+It is a constant work in progress as the language itself also progresses.")
+ (license license:gpl3+))))
--
2.29.2
next prev parent reply other threads:[~2020-11-05 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:20 [bug#44470] [PATCH] gnu: Added emacs-solidity Martin Becze
2020-11-05 17:07 ` Nicolas Goaziou
2020-11-05 19:50 ` Martin Becze
2020-11-05 19:52 ` Martin Becze [this message]
2020-11-05 22:29 ` bug#44470: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5805b82e-8aa5-d7ef-5fae-69a7d86ffe59@riseup.net \
--to=mjbecze@riseup.net \
--cc=44470@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.