From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aBUCNSZYpF8PDwAA0tVLHw (envelope-from ) for ; Thu, 05 Nov 2020 19:53:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2DDGMCZYpF83agAAB5/wlQ (envelope-from ) for ; Thu, 05 Nov 2020 19:53:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DC36940149 for ; Thu, 5 Nov 2020 19:53:10 +0000 (UTC) Received: from localhost ([::1]:46498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kalJk-0002uR-Uv for larch@yhetil.org; Thu, 05 Nov 2020 14:53:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kalJe-0002sd-7f for guix-patches@gnu.org; Thu, 05 Nov 2020 14:53:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kalJd-00030q-U6 for guix-patches@gnu.org; Thu, 05 Nov 2020 14:53:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kalJd-0004bp-TM for guix-patches@gnu.org; Thu, 05 Nov 2020 14:53:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44470] [PATCH] gnu: Added emacs-solidity. Resent-From: Martin Becze Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Nov 2020 19:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44470 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 44470@debbugs.gnu.org Received: via spool by 44470-submit@debbugs.gnu.org id=B44470.160460597317704 (code B ref 44470); Thu, 05 Nov 2020 19:53:01 +0000 Received: (at 44470) by debbugs.gnu.org; 5 Nov 2020 19:52:53 +0000 Received: from localhost ([127.0.0.1]:54183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kalJU-0004bS-VF for submit@debbugs.gnu.org; Thu, 05 Nov 2020 14:52:53 -0500 Received: from mx1.riseup.net ([198.252.153.129]:58276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kalJT-0004bJ-LS for 44470@debbugs.gnu.org; Thu, 05 Nov 2020 14:52:52 -0500 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4CRvM667RNzDt1l; Thu, 5 Nov 2020 11:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1604605970; bh=gQsgd733VVBzLrmZoK23EjQSg0RGhQwLl/UkXdCOKdk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Ay/FYWKAuWevPT4XcNmga7brJM0GBa/U2jbRqnYhI1oZBxkZ6ya+16jFAEzgwiS+4 0N2T9UCUeB7xxL6FpkdV49RdCULdYKbE/p8MLR3JR0P2giD2Pwm77LqoRZTyLCMGs/ ZSBqyph3vuAId4VRUogx1y3eKNtQHpwPpsAAk2Fc= X-Riseup-User-ID: 9D972595255ABB1353F3CFE23CC4A5485531FB721DA8EFEAA5B44FC834F3E862 Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 4CRvM53BCkzJpbM; Thu, 5 Nov 2020 11:52:49 -0800 (PST) References: <20201105152052.6017-1-mjbecze@riseup.net> <87zh3vlokf.fsf@nicolasgoaziou.fr> From: Martin Becze Message-ID: <5805b82e-8aa5-d7ef-5fae-69a7d86ffe59@riseup.net> Date: Thu, 5 Nov 2020 13:52:46 -0600 MIME-Version: 1.0 In-Reply-To: <87zh3vlokf.fsf@nicolasgoaziou.fr> Content-Type: multipart/mixed; boundary="------------20DAA720AF4052BCBDA86BE1" Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=riseup.net header.s=squak header.b=Ay/FYWKA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: OIwk7tbAKWb/ This is a multi-part message in MIME format. --------------20DAA720AF4052BCBDA86BE1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > If we use the commit above, `version' can simply become "0.1.10". Opps sorry missed this comment. Attached is a patch that fixes that too. On 11/5/20 11:07 AM, Nicolas Goaziou wrote: > Hello, > > Martin Becze writes: > >> * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable. > > Thank you. > >> + ;; No release. >> + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e")) > > Is there any reason to use this particular instead of > e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10" > release? If so, please mention it in the comment above. > >> + (package >> + (name "emacs-solidity") >> + (version (git-version "0.1.10" "1" commit)) > > If we use the commit above, `version' can simply become "0.1.10". > >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/ethereum/emacs-solidity") >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq")))) >> + (build-system emacs-build-system) >> + (propagated-inputs >> + `(("emacs-company" ,emacs-company) >> + ("emacs-flycheck" ,emacs-flycheck))) >> + (home-page "https://github.com/ethereum/emacs-solidity") >> + (synopsis "Major mode for writing Solidity code") >> + (description "A simple language mode for the Solidity language. It is a >> +constant work in progress as the language itself also progresses.") > > The first sentence should be "complete", i.e., with a subject and > a verb. > > Could you send an updated patch? > > Regards, > --------------20DAA720AF4052BCBDA86BE1 Content-Type: text/x-patch; charset=UTF-8; name="v3-0001-gnu-Added-emacs-solidity.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="v3-0001-gnu-Added-emacs-solidity.patch" >From c8f9487a07700f5ed17b2ddd726e30c4bf21acec Mon Sep 17 00:00:00 2001 From: Martin Becze Date: Thu, 5 Nov 2020 09:18:01 -0600 Subject: [PATCH v3] gnu: Added emacs-solidity. * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable. --- gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 2043ce19df..846429fbdf 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -25281,3 +25281,28 @@ the TypeScript implementation.") (description "This package provides an Emacs client for the Rocket.chat service.") (license license:expat)))) + +(define-public emacs-solidity + ;; This commit fixes a spacing issue and adds new keywords + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e")) + (package + (name "emacs-solidity") + (version "0.1.10") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ethereum/emacs-solidity") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-company" ,emacs-company) + ("emacs-flycheck" ,emacs-flycheck))) + (home-page "https://github.com/ethereum/emacs-solidity") + (synopsis "Major mode for writing Solidity code") + (description "This is a simple language mode for the Solidity language. +It is a constant work in progress as the language itself also progresses.") + (license license:gpl3+)))) -- 2.29.2 --------------20DAA720AF4052BCBDA86BE1--