From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] gnu: util-linux: Add "static" output.
Date: Sun, 3 Apr 2016 20:29:22 +0200 [thread overview]
Message-ID: <57016102.2090500@gmail.com> (raw)
In-Reply-To: <20160403005357.GF4959@jasmine>
[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]
Hullo Leo,
Thanks, as always, for the review!
On 03/04/16 02:53, Leo Famulari wrote:
> On Sat, Apr 02, 2016 at 03:29:33PM +0200, Tobias Geerinckx-Rice wrote:
>> + (add-after
>> + 'install 'move-static-libraries
>
> How about calling the phase 'install-static' as in your btrfs-progs
> patch?
The two phases do subtly (?) different things. INSTALL-STATIC calls an
additional ‘make install-static’ target that wouldn't be run otherwise.
MOVE-STATIC-LIBRARIES moves some static files already installed to OUT
by the default 'install phase to a different output, STATIC.
I don't think drawing explicit parallels between the two (by choosing
identical names) makes anything any clearer, but have no strong feelings
either way.
Kind regards,
T G-R
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-03 18:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 13:29 Update btrfs-progs once again and add static output Tobias Geerinckx-Rice
2016-04-02 13:29 ` [PATCH 1/3] gnu: btrfs-progs: Update to 4.5.1 Tobias Geerinckx-Rice
2016-04-03 0:51 ` Leo Famulari
2016-04-02 13:29 ` [PATCH 2/3] gnu: util-linux: Add "static" output Tobias Geerinckx-Rice
2016-04-03 0:47 ` Leo Famulari
2016-04-03 0:53 ` Leo Famulari
2016-04-03 18:29 ` Tobias Geerinckx-Rice [this message]
2016-04-03 19:21 ` Leo Famulari
2016-04-14 17:50 ` Thompson, David
2016-04-02 13:29 ` [PATCH 3/3] gnu: btrfs-progs: " Tobias Geerinckx-Rice
2016-04-03 0:50 ` Leo Famulari
2016-04-03 0:53 ` Update btrfs-progs once again and add static output Leo Famulari
2016-04-12 0:07 ` Leo Famulari
2016-04-12 7:13 ` Leo Famulari
2016-04-14 16:30 ` Ludovic Courtès
2016-04-14 18:58 ` Thompson, David
2016-04-15 1:34 ` Leo Famulari
2016-04-15 21:00 ` Ludovic Courtès
2016-04-16 1:11 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57016102.2090500@gmail.com \
--to=tobias.geerinckx.rice@gmail.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.