From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH 2/3] gnu: util-linux: Add "static" output. Date: Sun, 3 Apr 2016 20:29:22 +0200 Message-ID: <57016102.2090500@gmail.com> References: <1459603774-9455-1-git-send-email-tobias.geerinckx.rice@gmail.com> <1459603774-9455-3-git-send-email-tobias.geerinckx.rice@gmail.com> <20160403005357.GF4959@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d6TtnF69VggWpsM00CLCLl3rrsc4iJA63" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ammmL-0008C8-FD for guix-devel@gnu.org; Sun, 03 Apr 2016 14:29:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ammmG-0003Da-FQ for guix-devel@gnu.org; Sun, 03 Apr 2016 14:29:41 -0400 Received: from mail-lb0-x242.google.com ([2a00:1450:4010:c04::242]:36361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ammmF-0003DD-Jw for guix-devel@gnu.org; Sun, 03 Apr 2016 14:29:36 -0400 Received: by mail-lb0-x242.google.com with SMTP id q4so18090264lbq.3 for ; Sun, 03 Apr 2016 11:29:33 -0700 (PDT) In-Reply-To: <20160403005357.GF4959@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d6TtnF69VggWpsM00CLCLl3rrsc4iJA63 Content-Type: multipart/mixed; boundary="W8AQnlO4pQK5mqHVM9UuUMwsTPdFNnaG9" From: Tobias Geerinckx-Rice To: Leo Famulari Cc: guix-devel@gnu.org Message-ID: <57016102.2090500@gmail.com> Subject: Re: [PATCH 2/3] gnu: util-linux: Add "static" output. References: <1459603774-9455-1-git-send-email-tobias.geerinckx.rice@gmail.com> <1459603774-9455-3-git-send-email-tobias.geerinckx.rice@gmail.com> <20160403005357.GF4959@jasmine> In-Reply-To: <20160403005357.GF4959@jasmine> --W8AQnlO4pQK5mqHVM9UuUMwsTPdFNnaG9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hullo Leo, Thanks, as always, for the review! On 03/04/16 02:53, Leo Famulari wrote: > On Sat, Apr 02, 2016 at 03:29:33PM +0200, Tobias Geerinckx-Rice wrote: >> + (add-after >> + 'install 'move-static-libraries >=20 > How about calling the phase 'install-static' as in your btrfs-progs > patch? The two phases do subtly (?) different things. INSTALL-STATIC calls an additional =E2=80=98make install-static=E2=80=99 target that wouldn't be = run otherwise. MOVE-STATIC-LIBRARIES moves some static files already installed to OUT by the default 'install phase to a different output, STATIC. I don't think drawing explicit parallels between the two (by choosing identical names) makes anything any clearer, but have no strong feelings either way. Kind regards, T G-R --W8AQnlO4pQK5mqHVM9UuUMwsTPdFNnaG9-- --d6TtnF69VggWpsM00CLCLl3rrsc4iJA63 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXAWEKAAoJEJHM25tIVBuZUuMIAItR/54hyxLkqk4MkS+8r1zr x/f2uh9R/8n/sM5QOcAzJeRE/75YStTSD+2IvSzZAg4ku+lGtwSaDGkowqXQ+GZn PgK73J8h6cyJS9Q9g37FPdvrnqxDzlk0rWOWwtAFeUBPy5ygZNxyvYg+lvfXqJy1 wIXm8uwPzcD7/0ZclZXxtYaDR+l0kb2ZTuJxjuZ+SUCnCCIHbxGh1AkCPXS5Ipwn ZEWRzQdPIsfRA8/AFbHpICQ/YxGmoF4LMq0IKpkAghGmcxr7e4InK8P1jzwTNP7O KvCIcNuVhjlK2N7X7ljP6etnwsM6Z+Osp3zpmCrgGjCs8iKUwuI5vm8tWN5uRdc= =T/u7 -----END PGP SIGNATURE----- --d6TtnF69VggWpsM00CLCLl3rrsc4iJA63--